! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
No horizontal alignment in vertical panel
Status:
RESOLVED: MOVED
Product:
Xfce4-places-plugin
Component:
General

Comments

Description robertxgray 2019-06-07 19:42:50 CEST
Created attachment 8622 
Screenshot

Hi, since my xfce4-places-plugin has been updated from 1.7.0 to 1.8.0, it looks weird when placed in a vertical panel. It's not horizontally aligned as you can see in the screenshot. Thank you.
Comment 1 Andre Miranda editbugs 2019-06-09 15:09:13 CEST
I can reproduce with Adwaita, but not with greybird.
git bisect reveals this issue was introduce by this commit:
https://git.xfce.org/panel-plugins/xfce4-places-plugin/commit/?id=549855a
Comment 2 Andre Miranda editbugs 2019-06-09 15:54:23 CEST
I have added printfs to both ways of getting the image_size and removed the conditional macros.
When using xfce_panel_plugin_get_icon_size the prefix is "size1", while border thickness is prefixed with "size2". 

Output when using Greybird:
size1: 12
size2: 14
size1: 12
size2: 14
size1: 12
size2: 12
size1: 12
size2: 12
size1: 32
size2: 34

Output when using Adwaita:
size1: 12
size2: 14
size1: 12
size2: 14
size1: 12
size2: -4
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
size1: 12
size2: -4
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
size1: 32
size2: 18
Comment 3 Git Bot editbugs 2020-05-23 00:35:35 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-places-plugin/-/issues/27.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15572

Reported by:
robertxgray
Reported on: 2019-06-07
Last modified on: 2020-05-23

People

Assignee:
Andrzej
CC List:
1 user

Version

Attachments

Screenshot (79.42 KB, image/png)
2019-06-07 19:42 CEST , robertxgray
no flags

Additional information