! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add rsvg thumbnailer plugin
Status:
RESOLVED: MOVED
Product:
Tumbler
Component:
General

Comments

Description Olivier Duchateau 2019-06-07 13:05:45 CEST
Created attachment 8621 
Add rsvg thumbnailer plugin

This new plugin uses librsvg in order to create thumbnailer of SVG images, and especially .svgz, (SVG compressed format), not supported by GdkPixbuf.
Comment 1 Olivier Duchateau 2019-06-29 19:53:30 CEST
I found with librsvg >= 2.45.x when SVG image is embed into another one,  thumbnail is not created. This issue is not present with librsvg 2.44.x.
Comment 2 Ali Abdallah editbugs 2020-04-28 18:23:31 CEST
Sorry for this very late reply. 

Thanks for your contribution, I'll review it and add it soon.
Comment 3 Ali Abdallah editbugs 2020-05-01 12:06:21 CEST
(In reply to Olivier Duchateau from comment #1)
> I found with librsvg >= 2.45.x when SVG image is embed into another one, 
> thumbnail is not created. This issue is not present with librsvg 2.44.x.

I have your commit locally, and I'm still testing it. I have a couple of questions 

1. Is there is any reason why you set the requirement of the plugin on a  very recent release of librsvg >= 2.44.0? I personally don't have that, tested on librsvg 2.40.0 and it compiles and works just fine. 
2. If you can attach here an example of an embedded SVG image, that would be useful. Does it work with the pixbuf plugin disabling yours?
Comment 4 Git Bot editbugs 2020-05-25 23:20:09 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/tumbler/-/issues/20.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15569

Reported by:
Olivier Duchateau
Reported on: 2019-06-07
Last modified on: 2020-05-25

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Attachments

Add rsvg thumbnailer plugin (24.49 KB, patch)
2019-06-07 13:05 CEST , Olivier Duchateau
no flags

Additional information