! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Disable SVN/GIT menu items when not in a repository
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Thunar-vcs-plugin
Component:
General

Comments

Description scootergrisen 2019-06-07 04:12:20 CEST
Right click the desktop.
Seems the SVN and GIT menu items are still in the context menu even when they are not sub menus.
Clicking them seems to do nothing.

So perhaps they should only be in the menu if they are relavant or they could be greyed out like Paste is when the clipboard is empty so the user is unable to select them if they will not work anyway.
Comment 1 Andre Miranda editbugs 2019-06-09 13:01:58 CEST
I don't have svn around, but the git menu is always populated even when not in a git repository folder, clicking on some actions will fail complaining "fatal: not a git repository".
Comment 2 scootergrisen 2019-06-10 16:26:44 CEST
Right clicking the desktop give SVN and GIT in the context menu but they are not submenus.
Right click the desktop folder in Thunar and SVN and GIT is submenus.
Comment 3 Andre Miranda editbugs 2019-06-17 00:31:47 CEST
I agree with the proposed change, it's possible to disable git or svn when not in a valid repository, I just don't have the time to put together a patch.

(In reply to scootergrisen from comment #2)
> Right clicking the desktop give SVN and GIT in the context menu but they are
> not submenus.
That's another problem, xfdesktop doesn't support ThunarxMenu which allows submenus.
Comment 4 Git Bot editbugs 2020-05-20 21:34:05 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/thunar-plugins/thunar-vcs-plugin/-/issues/12.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15568

Reported by:
scootergrisen
Reported on: 2019-06-07
Last modified on: 2020-05-20

People

Assignee:
Peter de Ridder
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information