Latest Thunar SVN won't build. Reproducible: Always Steps to Reproduce: cc1: warnings being treated as errors thunar-vfs-mime-legacy.c: In function 'thunar_vfs_mime_legacy_parse_magic_line': thunar-vfs-mime-legacy.c:1074: warning: pointer targets in assignment differ in signedness thunar-vfs-mime-legacy.c:1084: warning: pointer targets in assignment differ in signedness make[3]: *** [libthunar_vfs_1_la-thunar-vfs-mime-legacy.lo] Error 1 make[3]: Leaving directory `/opt/xfce4-svn/src/xfce4svn/thunar/trunk/thunar-vfs' make[2]: *** [all] Error 2 make[2]: Leaving directory `/opt/xfce4-svn/src/xfce4svn/thunar/trunk/thunar-vfs' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/opt/xfce4-svn/src/xfce4svn/thunar/trunk' make: *** [all] Error 2
Created attachment 468 Suggested fix This patch should fix the problem.
Now I get a new problem: thunar-vfs-xfer.c: In function 'tvxc_mounted_readonly': thunar-vfs-xfer.c:140: error: 'struct statfs' has no member named 'f_flags' thunar-vfs-xfer.c:140: error: 'MNT_RDONLY' undeclared (first use in this function) thunar-vfs-xfer.c:140: error: (Each undeclared identifier is reported only once thunar-vfs-xfer.c:140: error: for each function it appears in.) make[3]: *** [libthunar_vfs_1_la-thunar-vfs-xfer.lo] Error 1 make[3]: Leaving directory `/opt/xfce4-svn/src/xfce4svn/thunar/trunk/thunar-vfs'make[2]: *** [all] Error 2 make[2]: Leaving directory `/opt/xfce4-svn/src/xfce4svn/thunar/trunk/thunar-vfs'make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/opt/xfce4-svn/src/xfce4svn/thunar/trunk' make: *** [all] Error 2
Created attachment 469 2nd one This should fix both problems.
(In reply to comment #3) > Created an attachment (id=469) [edit] > 2nd one > > This should fix both problems. It does indeed fix both problems. Thanks, Benny :)
Fixed with revision 20277. 2006-03-07 Benedikt Meurer <benny@xfce.org> * thunar-vfs/thunar-vfs-mime-legacy.c: Fix gcc4 warnings. Bug #1556. * thunar-vfs/thunar-vfs-xfer.c: Prefer statvfs() over statfs() on systems that provide both. Bug #1556.