! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Feature request: Add dark theme mode switch
Status:
RESOLVED: WONTFIX
Product:
Xfce4-settings
Component:
Appearance Settings

Comments

Description Maurizio Galli 2019-05-31 12:07:58 CEST
I would like to kindly request a switch in appearance to call dark theme mode through gtk-application-prefer-dark-theme = true

Could you please add this switch to the apperance > theme screen?

Thank you
Comment 1 Simon Steinbeiss editbugs 2019-06-10 23:24:34 CEST
I guess this feature would be easily do-able, but it relies on themes providing a dark version.

What happens if a theme doesn't have a dark version? Is Adwaita used as fallback?
I'm mostly concerned about users being confused about what happens in case themes don't provide those dark variants...
Comment 2 Maurizio Galli 2019-06-11 04:07:31 CEST
(In reply to Simon Steinbeiss from comment #1)

> What happens if a theme doesn't have a dark version? Is Adwaita used as
> fallback?
> I'm mostly concerned about users being confused about what happens in case
> themes don't provide those dark variants...

a) make it fallback to Adwaita, since it's pretty safe to assume it's installed by everyone,
b) have a banner saying "this theme does not support dark mode"
Comment 3 Maurizio Galli 2020-01-29 05:54:08 CET
Is this still something worth implementing now that Adwaita, Greybird etc all seem to have dark themes?
Comment 4 Simon Steinbeiss editbugs 2020-01-29 08:19:24 CET
It's the other way round: there is no good/easy way to provide a system wide switch, so people starting splitting up themes...
Comment 5 Simon Steinbeiss editbugs 2020-05-28 00:11:08 CEST
As long as there is no global setting in Gtk we can't properly fix this.

Bug #15509

Reported by:
Maurizio Galli
Reported on: 2019-05-31
Last modified on: 2020-05-28

People

Assignee:
Simon Steinbeiss
CC List:
2 users

Version

Version:
4.13.6

Attachments

Additional information