! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Logout dialog ignores font size


Description skontar 2019-05-30 10:45:25 CEST
It seems that the new version of the logout dialog does not respect overall system font size settings. Also the Greybird theme does not seem to work fully.
Comment 2 Theo Linkspfeifer editbugs 2019-06-14 19:00:18 CEST
Another styling class was added to the logout dialog [1], and it sets the font size to "smaller" [2].

[1] https://git.xfce.org/xfce/xfce4-session/commit/?id=d11864682bb63efcf8ae6ad410afe332e906bec9
[2] https://github.com/shimmerproject/Greybird/blob/master/gtk-3.0/gtk-contained.css#L4459
Comment 3 Simon Steinbeiss editbugs 2019-06-14 22:39:18 CEST
I guess we can reset the font size in some injected css just to be sure. The general idea of adding this style-class was to use the general style for undecorated dialogs by default.
Comment 4 Simon Steinbeiss editbugs 2019-06-15 23:14:23 CEST
Re-setting the font size to e.g. normal may also override themes which set it to a larger/smaller value, so that's not ideal.

I will change the font size of this specific dialog in Greybird and in Adwaita it'll remain as is.
Comment 5 Simon Steinbeiss editbugs 2019-06-27 01:40:20 CEST
Created attachment 8692 
Patch resetting the font-size

Please test the attached patch if possible.
Comment 6 Andre Miranda editbugs 2019-06-27 16:04:06 CEST
(In reply to Simon Steinbeiss from comment #5)
> Created attachment 8692 
> Patch resetting the font-size
> Please test the attached patch if possible.

You can add g_object_unref (provider) after gtk_style_context_add_provider.
Comment 7 Andre Miranda editbugs 2019-06-27 16:11:03 CEST
Forgot to mention: LGTM.
Comment 8 Git Bot editbugs 2019-06-29 00:27:03 CEST
Simon Steinbeiss referenced this bugreport in commit 7e00dcf456e2c6bc05ab51e662e8c5cc0625d181

Reset font-size of logout dialog to default (Bug #15505)

Comment 9 Simon Steinbeiss editbugs 2019-06-29 00:27:34 CEST
> You can add g_object_unref (provider) after gtk_style_context_add_provider.

Thanks, fixed that oversight.

Bug #15505

Reported by:
Reported on: 2019-05-30
Last modified on: 2019-06-29


Simon Steinbeiss
CC List:
3 users




Patch resetting the font-size (3.24 KB, patch)
2019-06-27 01:40 CEST , Simon Steinbeiss
no flags

Additional information