Comment 1 Andre Miranda 2019-05-26 23:50:28 CEST

I can't reproduce, any steps?

Comment 2 Theo Linkspfeifer 2019-05-26 23:58:47 CEST

Create launchers/URL links until it happens.

Comment 3 Git Bot 2019-06-09 13:52:42 CEST

Andre Miranda referenced this bugreport in commit 0b7bdee8665088280820c20d6e363138903d70ed

Rename Camelcase to Title Case (Bug #15460)

https://git.xfce.org/xfce/thunar/commit?id=0b7bdee8665088280820c20d6e363138903d70ed

Comment 4 Andre Miranda 2019-06-09 13:53:43 CEST

Oh, ignore that last message, multitasking is not safe...

Comment 5 Andre Miranda 2019-06-09 13:55:01 CEST

If anyone gets here from git history, the correct bug for that is Bug 15579.

Comment 6 Andre Miranda 2019-06-09 16:31:28 CEST

@Theo:
I'm following this procedure:
- Right click on desktop and select "Create Launcher"
- Write a number in the "Name" field
- Write "echo" in the "Command" field
- Press enter

I created 10+ launchers and not critical messages so far.

Comment 7 Theo Linkspfeifer 2019-06-24 15:50:53 CEST

$ exo-desktop-item-edit --name=1 --command=1 ~/Desktop/1.desktop

If I keep running this command to create/save a launcher, the error will be triggered after few tries.

Comment 8 Andre Miranda 2019-06-24 16:00:19 CEST

No luck, I'm running the following (zsh):
$ for i in {1..100}; do exo-desktop-item-edit --name=$i --command=$i ~/Desktop/$i.desktop; done

By the way, the stacktrace on #c0 refers to xfdesktop_regular_file_icon_new, I don't see how exo-desktop-item-edit could be related, maybe another bug?

Comment 9 Theo Linkspfeifer 2019-06-24 17:26:48 CEST

Error message from g_file_query_info():
Failed to query file info: Error when getting information for file “/home/theo/Desktop/1.desktop.LT113Z”: No such file or directory

The xfdesktop code does not actually check if regular_file_icon->priv->file_info != NULL, see:
https://git.xfce.org/xfce/xfdesktop/tree/src/xfdesktop-regular-file-icon.c#n1040

Comment 10 Theo Linkspfeifer 2019-07-27 14:52:37 CEST

Created attachment 8815 
patch?

Comment 11 Andre Miranda 2019-07-30 03:26:44 CEST

(In reply to Theo Linkspfeifer from comment #10)
> Created attachment 8815 
> patch?

hmmm, querying the file again looks wrong, does this patch fix the issue for you?

Comment 12 Theo Linkspfeifer 2019-07-30 10:52:54 CEST

It does.

Comment 13 Git Bot 2019-07-31 03:10:41 CEST

Theo Linkspfeifer referenced this bugreport in commit 5e36bfed4e726710946c8edf32d47fed469aa2e2

Do not query file information again (Bug #15460)

https://git.xfce.org/xfce/xfdesktop/commit?id=5e36bfed4e726710946c8edf32d47fed469aa2e2

Comment 14 Andre Miranda 2019-07-31 03:13:32 CEST

Well, I could reproduce the issue, although it's very hard for me, it happens once in ~150 attempts.
The patch seems to fix the problem, thanks.