! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Xfwm 4.13.2 fails to compile with --disable-compositor
Status:
RESOLVED: FIXED

Comments

Description bugzilla 2019-05-20 23:51:27 CEST
Compilation succeeds with --enable-compositor but fails with --disable-compositor. Excerpt from the build.log generated via Portage:

compositor.h:82:1: error: unknown type name 'vblankMode'
   82 | vblankMode               compositorVblankMode                   (const gchar *);
      | ^~~~~~~~~~
compositor.c:4901:1: error: unknown type name 'vblankMode'
 4901 | vblankMode
      | ^~~~~~~~~~
compositor.c: In function 'compositorVblankMode':
compositor.c:4914:16: error: 'VBLANK_GLX' undeclared (first use in this function)
 4914 |         return VBLANK_GLX;
      |                ^~~~~~~~~~
compositor.c:4914:16: note: each undeclared identifier is reported only once for each function it appears in
compositor.c:4920:16: error: 'VBLANK_OFF' undeclared (first use in this function)
 4920 |         return VBLANK_OFF;
      |                ^~~~~~~~~~
compositor.c:4923:12: error: 'VBLANK_AUTO' undeclared (first use in this function)
 4923 |     return VBLANK_AUTO;
      |            ^~~~~~~~~~~
Comment 1 Git Bot editbugs 2019-05-21 22:01:35 CEST
Olivier Fourdan referenced this bugreport in commit bc07c4a1d21ea372b7d28d74987e376b0816a3d0

compositor: Fix build without compositor

https://git.xfce.org/xfce/xfwm4/commit?id=bc07c4a1d21ea372b7d28d74987e376b0816a3d0
Comment 2 Git Bot editbugs 2019-05-21 22:06:13 CEST
Olivier Fourdan referenced this bugreport in commit 373efbc6eed30bd995021d0067a0b7ba5d528cfe

compositor: Add missing prototype declaration

https://git.xfce.org/xfce/xfwm4/commit?id=373efbc6eed30bd995021d0067a0b7ba5d528cfe
Comment 3 Dridi 2019-10-04 23:47:24 CEST
I think this ticket can be closed, it has been addressed by two commits and I can build the master branch fine either way on my system.

Bug #15432

Reported by:
bugzilla
Reported on: 2019-05-20
Last modified on: 2020-05-21

People

Assignee:
Olivier Fourdan
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information