! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Change "Action" below the title to something better
Status:
RESOLVED: FIXED
Product:
Xfce4-screenshooter
Component:
General

Comments

Description scootergrisen 2019-05-20 14:44:18 CEST
The string "Action" appear twice in the Screenshot dialog.

Below the title "Screenshot" it says "Action" but that dont really say much so maybe find something better to write there.

Above the radiobuttons it says "Action" and that makes more sense.

In the po file it seems the string is only suppose to be used one place:
#: ../lib/screenshooter-dialogs.c:908
msgid "Action"

So maybe its a mistake that it also gets used below the title.
Comment 1 scootergrisen 2019-05-20 14:57:47 CEST
Seems there are two kinds of screenshooter dialogs if not three.

If i select the plugin preferences i see a dialog also identical to if i run xfce4-screenshooter but not identical.
The title below "Screenshot" and the buttons are different.

And if i click the plugin icon i see the dialog with "Action" which have the preview image.
That seems to be run with wrapper-2.0 libscreenshooterplugin.so.

Maybe a little confusing to have 3 different kinds of dialogs for almost the same.
So maybe better to combine them into one.
Seems one if for saving to clipboard only.
Comment 2 scootergrisen 2019-05-20 14:58:19 CEST
Also there dont seem to be a product in bugzilla for the screenshooter plugin.
Comment 3 Andre Miranda editbugs 2019-05-20 17:10:56 CEST
(In reply to scootergrisen from comment #0)
> Below the title "Screenshot" it says "Action" but that dont really say much
> so maybe find something better to write there.
For instance?
Comment 4 scootergrisen 2019-05-20 19:46:18 CEST
If the two dialogs are combined into one it would get rid of "Action" subtitle and use the other subtitle "Take a screenshot" which is better.

The 2 dialogs can be seen at the bottom of https://goodies.xfce.org/projects/applications/xfce4-screenshooter

Its a little confusing for a user to have two dialogs called the same that almost does the same but are different.
Comment 5 Andre Miranda editbugs 2019-05-21 02:31:03 CEST
There are only two dialogs:

1 - The one before taking the screenshot, where the subtitle is "Take a screenshot". The same dialog is reused as the plugin's preferences, thus a different subtitle and buttons, because the screenshot will not be taken.
2 - The on after taking the screenshot, that's the one this bug report is for, so let's focus on it.

Sorry but I'm more creative with code than with natural language, the best I can think of is "Choose what to do with the screenshot".
Comment 6 scootergrisen 2019-05-21 03:51:05 CEST
Maybe just close this bug then and i make a new one.

Because if the confusen with the dialog is fixed it will fix this bug to.
Comment 7 Andre Miranda editbugs 2019-05-21 18:53:29 CEST
(In reply to scootergrisen from comment #6)
> Maybe just close this bug then and i make a new one.
I think the proposal to improve the subtitle (of the second dialog) is a valid request, I'm still expecting suggestions though.

> Because if the confusen with the dialog is fixed it will fix this bug to.
Nothing was fixed, I hope to have clarified what are the existing dialogs and how the first one might change depending of the context it's called.
Comment 8 scootergrisen 2019-05-21 19:46:52 CEST
I think "Choose what to do with the screenshot" is fine.
Or maybe "What to do with the screenshot".

Or maybe "Screenshot was captured", "Screenshot has been captured", "The screenshot has been captured" or "Screenshot captured".

How about changing the first OK button to Capture to make it more clear the first dialog takes the screenshot.



When clicking the plugin icon having a subtitle like "Screenshot was captured" could be nice because it might not be clear that the screenshot have already been taken.
Comment 9 Git Bot editbugs 2019-10-06 23:19:24 CEST
Andre Miranda referenced this bugreport in commit 6f04eb3f6c4f9cdd971e22021a9ed3e6955077b1

Improve wording (Bug #15429)

https://git.xfce.org/apps/xfce4-screenshooter/commit?id=6f04eb3f6c4f9cdd971e22021a9ed3e6955077b1
Comment 10 Andre Miranda editbugs 2019-10-06 23:23:32 CEST
(In reply to scootergrisen from comment #8)
> Or maybe "Screenshot was captured", "Screenshot has been captured", "The
> screenshot has been captured" or "Screenshot captured".
> 
> How about changing the first OK button to Capture to make it more clear the
> first dialog takes the screenshot.
"Capture" would be inconsistent with "Take a screenshot" in the previous dialog (I know there is a "Region to capture" label, I just don't want to make it worse).

> When clicking the plugin icon having a subtitle like "Screenshot was
> captured" could be nice because it might not be clear that the screenshot
> have already been taken.

I think "Choose what to do with the screenshot" is a good enough indication that the screenshot has been captured.

Bug #15429

Reported by:
scootergrisen
Reported on: 2019-05-20
Last modified on: 2019-10-06

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Additional information