! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Replace text "Enter the new name:" by "Enter the name:" for file creation dialog
Status:
RESOLVED: FIXED

Comments

Description scootergrisen 2019-05-20 13:08:36 CEST
When i right click the desktop to create a new folder or file it says:

    Enter the new name:

Maybe "new" does not make so much sense when creating a folder or file.
Renaming i guess makes sense but maybe this is better for all cases:

    Enter the name:

Or just:

    Name:



Perhaps have "Name:" to the left of the input box just like when creating URL link and starters and in properties dialog to be consistent.
Comment 1 alexxcons editbugs 2019-05-20 22:49:09 CEST
Agreed, "Enter the name:" should be sufficient. To
Comment 2 alexxcons editbugs 2019-05-20 22:50:37 CEST
Created attachment 8555 
fix
Comment 3 Andre Miranda editbugs 2019-05-22 03:31:10 CEST
error: patch failed: thunar/thunar-create-dialog.c:153
error: thunar/thunar-create-dialog.c: patch does not apply

Applied the change manually, looks good because it doesn't affect the rename dialog but notice that we are currently under Soft String Freeze[1], so we should only change strings when really necessary. It can pushed to master, we just need to remember to cherry-pick after 4.14.

1- https://wiki.xfce.org/releng/4.14/roadmap#schedule
Comment 4 alexxcons editbugs 2019-05-22 13:32:39 CEST
Ops, possibly build the patch against 4.12 on accident.

Yes, I'll push it to master only and cherry-pick it into the 4.14 branch after 4.14  got released  (or even just keep it in master? )
Comment 5 Git Bot editbugs 2019-05-23 10:33:52 CEST
Alexander Schwinn referenced this bugreport in commit d5eb85591427eac5ce7bf227f519e21ada24b5da

Replace text "Enter the new name:" by "Enter the name:" for file creation dialog (Bug #15423)

https://git.xfce.org/xfce/thunar/commit?id=d5eb85591427eac5ce7bf227f519e21ada24b5da
Comment 6 alexxcons editbugs 2019-05-23 10:34:07 CEST
fixed for master
Comment 7 Git Bot editbugs 2019-08-29 22:10:41 CEST
Alexander Schwinn referenced this bugreport in commit c134d378f635c23e26b18a944e33a83b1a38cc91

Replace text "Enter the new name:" by "Enter the name:" for file creation dialog (Bug #15423)

https://git.xfce.org/xfce/thunar/commit?id=c134d378f635c23e26b18a944e33a83b1a38cc91
Comment 8 alexxcons editbugs 2019-08-29 22:11:27 CEST
and now as well for 4.14 branch

Bug #15423

Reported by:
scootergrisen
Reported on: 2019-05-20
Last modified on: 2019-08-29

People

Assignee:
alexxcons
CC List:
2 users

Version

Attachments

fix (1.05 KB, patch)
2019-05-20 22:50 CEST , alexxcons
no flags

Additional information