! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Open all selected icons on key press
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Theo Linkspfeifer editbugs 2019-05-19 20:13:35 CEST
All selected icons should be opened/executed when pressing the Enter key, and they should not be unselected afterwards (same as when doing right-click > open all).
Comment 1 Theo Linkspfeifer editbugs 2019-05-19 20:15:10 CEST
Created attachment 8542 
proposed patch
Comment 2 Theo Linkspfeifer editbugs 2019-05-20 14:29:32 CEST
This needs some more work.
Comment 3 Theo Linkspfeifer editbugs 2019-05-20 16:24:43 CEST
Created attachment 8553 
diff

Some rework. I think that icons should be unselected on key press and last cursor position should not be reset.
Comment 4 Andre Miranda editbugs 2019-05-27 00:04:33 CEST
(In reply to Theo Linkspfeifer from comment #3)
> Created attachment 8553 
> diff
> 
> Some rework. I think that icons should be unselected on key press and last
> cursor position should not be reset.

Looks good, but I agree the selection shouldn't change. Getting rid of "xfdesktop_icon_view_unselect_all(icon_view);" doesn't seems to cause any harm. Can you please double check and send a patch with commit info? Thanks.

Also Thunar could benefit from this as well.
Comment 5 Theo Linkspfeifer editbugs 2019-05-27 22:48:11 CEST
Created attachment 8589 
patch

Removed that line.
Comment 6 Git Bot editbugs 2019-05-28 02:56:22 CEST
Theo Linkspfeifer referenced this bugreport in commit 1a3e8a298775a7311dcdb77692a9c93e6b095b29

Open all selected icons on key press (Bug #15420)

https://git.xfce.org/xfce/xfdesktop/commit?id=1a3e8a298775a7311dcdb77692a9c93e6b095b29
Comment 7 Andre Miranda editbugs 2019-05-28 02:59:42 CEST
Merged, thanks!

Bug #15420

Reported by:
Theo Linkspfeifer
Reported on: 2019-05-19
Last modified on: 2019-05-28

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.13.4

Attachments

proposed patch (1.44 KB, patch)
2019-05-19 20:15 CEST , Theo Linkspfeifer
no flags
diff (5.44 KB, patch)
2019-05-20 16:24 CEST , Theo Linkspfeifer
no flags
patch (5.78 KB, patch)
2019-05-27 22:48 CEST , Theo Linkspfeifer
no flags

Additional information