! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfwm4: 'wmctrl -r ":ACTIVE:" -b add,hidden' does not minimize the active window
Status:
RESOLVED: FIXED

Comments

Description pnd23 2019-05-03 19:40:37 CEST
Created attachment 8480 
proposed patch

After creating some panel launcher buttons to maximize (toggle), minimize and
close the active window (reason: handle maximized windows when the titlebar is
not shown), maximizing and closing windows succeed using the launcher buttons,
while hiding windows does not. This was tested on xfwm4_4.12.15-1 and
xfwm4_4.13.1-3.

Commands used by the launchers:

 - close window:
      wmctrl -c ":ACTIVE:"

 - toggle maximize window:
      wmctrl -r ":ACTIVE:" -b toggle,maximized_vert,maximized_horz

 - hide window:
      wmctrl -r ":ACTIVE:" -b add,hidden

Patching the "clientUpdateNetState" function in "netwm.c" to handle
"NET_WM_STATE_HIDDEN" state changes resolves the issue (tested on
xfwm_4.12.5-1; the reported version 4.12.5-1.1 is the patched version).

A proposed patch is included.
Comment 1 Git Bot editbugs 2019-05-03 20:01:19 CEST
pnd23@telenet.be referenced this bugreport in commit 70832c81246b2590524d3902412875e490f9b2b8

netwm: Allow hiding windows using NET_WM_STATE_HIDDEN

https://git.xfce.org/xfce/xfwm4/commit?id=70832c81246b2590524d3902412875e490f9b2b8
Comment 2 Olivier Fourdan editbugs 2019-05-03 20:02:20 CEST
Thanks, pushed!

Next time, please make sure to provide a git format patch against master.

Bug #15356

Reported by:
pnd23
Reported on: 2019-05-03
Last modified on: 2019-05-03

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
unspecified

Attachments

proposed patch (1.64 KB, patch)
2019-05-03 19:40 CEST , pnd23
no flags

Additional information