! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
missing check for pkgconfig(dbus-glib-1)
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfce4-pulseaudio-plugin
Component:
General

Comments

Description olaf 2019-04-30 18:45:45 CEST 
panel-plugin/pulseaudio-config.h uses dbus/dbus-glib.h, but configure.ac has no check if dbus-glib-1 is actually installed.

parole (for example) has this in configure.ac:
XDT_CHECK_PACKAGE([DBUS_GLIB], [dbus-glib-1], [dbus_glib_minimum_version])
Comment 1 Skunnyk editbugs 2019-05-02 18:33:09 CEST 
pulseaudio-plugin uses gdbus in mpris functionnality, and old dbus-glib for other ones…

dbus-glib is deprecated (https://dbus.freedesktop.org/doc/dbus-glib/), pulseaudio-plugin should be migrated entirely to gdbus.

Help welcome :)
Comment 2 Skunnyk editbugs 2019-07-07 00:11:01 CEST 
Created attachment 8731 
remove useless dbus-glib include
Comment 3 Git Bot editbugs 2020-03-29 03:26:05 CEST 
Romain Bouvier referenced this bugreport in commit 93aefcbeb147c468982b7b442b881c4a535b1b98

Removed useless dbus-glib include

https://git.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/commit?id=93aefcbeb147c468982b7b442b881c4a535b1b98
Comment 4 Sean Davis editbugs 2020-03-29 03:26:27 CEST 
Patch applied above. Thanks!

Bug #15343

Reported by:
olaf
Reported on: 2019-04-30
Last modified on: 2020-03-29

People

Assignee:
Sean Davis
CC List:
1 user

Version

Version:
0.4.1
Target Milestone:
---

Attachments

remove useless dbus-glib include (1.34 KB, patch)
2019-07-07 00:11 CEST , Skunnyk 		no flags

Additional information