15311 – Xfce4 menu misaligned on scaled displays

Xfce4 menu misaligned on scaled displays

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfwm4

Component:

General

Comments

Description Jason Zaman 2019-04-21 04:13:31 CEST

Created attachment 8434 
0001-menu-Fix-alignment-when-scaled.patch

On scaled displays, the menu position needs to be specified in
app-pixels. Some code paths to opening the menu are already in
app-pixels so do not require scaling. The height of the titlebar on
windows with frames always needs to be scaled.

Signed-off-by: Jason Zaman <jason@perfinion.com>

The attached patch fixes the issue on my setup, 4k monitor + HD Monitor (xrandr scaled to match the 4k) and with GDK_SCALE=2 everywhere.
Also, xfwm4 is missing a gitignore, a patch for that is also attached.

Comment 1 Jason Zaman 2019-04-21 04:14:38 CEST

Created attachment 8435 
0002-Add-gitignore.patch

Comment 2 Jason Zaman 2019-04-21 04:18:53 CEST

The patches are also here if thats easier to pull: https://github.com/perfinion/xfwm4/commits/menuscale

Comment 3 Olivier Fourdan editbugs

2019-04-21 11:19:03 CEST

Applied, thanks.

Bug #15311

Reported by:
Jason Zaman

Reported on: 2019-04-21
Last modified on: 2019-04-21

People

Assignee:
Olivier Fourdan

CC List:
0 users

Version

Version:
unspecified

Target Milestone:
Xfce 4.12

Attachments

0001-menu-Fix-alignment-when-scaled.patch (4.06 KB, patch) 2019-04-21 04:13 CEST , Jason Zaman	no flags
0002-Add-gitignore.patch (1.32 KB, patch) 2019-04-21 04:14 CEST , Jason Zaman	no flags

Additional information