! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Panel weather icons do not correspond to the correct timezone
Status:
RESOLVED: DUPLICATE
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description andrewclive 2019-04-20 01:40:00 CEST
Created attachment 8427 
Image of the problem

In time zone Japan - UTC +9, the panel plugin shows night icons during the day, and day icons during the night.
Comment 1 ndk 2019-06-15 11:17:45 CEST
I can confirm this bug...icons displayed should be based on "local time" -- not UTC.
Comment 2 Daniel 2019-06-26 13:03:29 CEST
I can also confirm this bug. It is surprisingly irritating. I'm in Australia.
Comment 3 Mateus 2019-07-27 04:48:42 CEST
I'm having the same problem here. I'm in Japan, now it's 11:48 am, very sunny, and the icon is a moon...
Comment 4 Goran 2019-08-02 16:17:02 CEST
Created attachment 8836 
Patch for parsing of sunrise API data

I think this patch should fix it, the times from the sunrise API seemed to have been converted to UTC, but not back to localtime for the call to is_night_time, which then determines the icon.
I've verified that the astro->sunrise/sunset times are now actual local times, but I'm not sure if the patch screws up anything else (such as the cache), it'd be great if someone could test it.
Comment 5 andrewclive 2019-08-02 23:25:14 CEST
Goran
Thanks for the patch. I can test it, but I'm not sure how. Where do I add the code?
Comment 6 Mateus 2019-08-03 02:33:40 CEST
I would like to test the patch too, but have no idea how. There is any step-by-step that teaches how, from downloading the source code to making it work?
Comment 7 deadown 2019-09-02 02:32:29 CEST
Created attachment 8978 
Weather plugin patch for local time.
Comment 8 deadown 2019-09-02 02:35:20 CEST
Comment on attachment 8978 
Weather plugin patch for local time.

Download the weather plugin here :

https://github.com/xfce-mirror/xfce4-weather-plugin 

then unzip the attachment in  the panel-plugin folder to replace the files.

Then compile and install.

This patch fixed the problem for me.
Comment 9 Mikhail Efremov 2019-11-22 18:10:01 CET
I didn't notice this bug report, so submitted a patch to https://bugzilla.xfce.org/show_bug.cgi?id=16091 (there is the same issue).

(In reply to deadown from comment #8)
> This patch fixed the problem for me.

Not only sunset/sunrise time need to be fixed, the moonrise/moonset times should be fixed  too.
Comment 10 ndk 2020-02-26 23:51:06 CET
This is still a regression bug in the new version xfce4-weather-plugin 0.10.1-1. 

Any update?

☹️
Comment 11 Sean Davis editbugs 2020-03-01 05:40:49 CET
Fixed in #16091

*** This bug has been marked as a duplicate of bug 16091 ***

Bug #15308

Reported by:
andrewclive
Reported on: 2019-04-20
Last modified on: 2020-03-01

People

Assignee:
Harald Judt
CC List:
8 users

Version

Version:
0.8.10

Attachments

Image of the problem (97.41 KB, image/png)
2019-04-20 01:40 CEST , andrewclive
no flags
Patch for parsing of sunrise API data (2.78 KB, patch)
2019-08-02 16:17 CEST , Goran
tiny.lasagna : review?
Weather plugin patch for local time. (30.30 KB, patch)
2019-09-02 02:32 CEST , deadown
no flags

Additional information