! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-panel's taskbar hides and does not allow transients to be minimized/res...
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description Olivier Fourdan editbugs 2019-04-19 23:02:16 CEST
Description:

To fix bug 14953 and allow regular transients to be hidden and restored, the taskbar need to show those otherwise the user may not be able to restore the transient windows once hidden (this is a usability issue).

Patch attached.
Comment 1 Olivier Fourdan editbugs 2019-04-19 23:10:34 CEST
Created attachment 8424 
[PATCH] tasklist: Show transient windows

With the fix for xfwm4 bug 14953, which allows regular transient windows
to be minimized independently from their parent window, the taskbar
needs to show those windows otherwise users won;t be able to restore the
windows from the taskbar.
Comment 2 Olivier Fourdan editbugs 2019-04-20 17:38:16 CEST
Created attachment 8428 
[PATCH] tasklist: Activate parent windows

With the fix for xfwm4 bug 14953, which allows regular transient windows
to be minimized independently from their parent window, the taskbar
needs to activate the parent window instead of the highest transient
otherwise using the taskbar would just show/hide the toplevel instead of
activating the parent window.
Comment 3 Simon Steinbeiss editbugs 2019-04-20 23:46:07 CEST
Hi Olivier, thanks I successfully tested the patch with the reproducer from bug 14593.

One thing I noticed (and I guess there's nothing much we can do about this) is that the current sort order does not reflect the window relationship expressed through the "transient" setting, so it's possible that the "parent" and its "children" will not appear next to each other or in inverse (first the children, then the parent) or mixed-up order.

Do you handle this in Xfwm4's tabwin at all or do you simply sort by timestamp there?
Comment 4 Olivier Fourdan editbugs 2019-04-21 11:11:07 CEST
(In reply to Simon Steinbeiss from comment #3)
> Do you handle this in Xfwm4's tabwin at all or do you simply sort by
> timestamp there?

In xfwm4, it's the MRU (most recently used) list used for tabwin. Not something we can do in the taskbar though...
Comment 5 Git Bot editbugs 2019-04-21 22:12:56 CEST
Olivier Fourdan referenced this bugreport in commit 7dd473f8a77f6998e816fdfc5f0b2f5de07f3f2e

tasklist: Activate parent windows (Bug #15307)

https://git.xfce.org/xfce/xfce4-panel/commit?id=7dd473f8a77f6998e816fdfc5f0b2f5de07f3f2e
Comment 6 Simon Steinbeiss editbugs 2019-04-21 22:14:40 CEST
Right, in that case let's go with your proposed patch. With grouping enabled in the tasklist it's actually not that bad...

Bug #15307

Reported by:
Olivier Fourdan
Reported on: 2019-04-19
Last modified on: 2019-04-21

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information