! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Xfdesktop not getting focus
Status:
VERIFIED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Mikko Linnalo 2006-03-03 15:21:56 CET
- Xfdesktop not getting focus when delete action is cancelled and delete is
pressed again
- Xfdesktop is not getting focus when clicked while Ctrl is pressed

Reproducible: Always
Steps to Reproduce:
1. Click an file in desktop to make it active
2. Press delete
3. Press enter (or select Cancel otherwise)
4. Press delete again
5. Nothing happens, delete confirmation dialog should be shown

Or

1. Another window is active (e.g. Thunar)
2. Keep Ctrl pressed and select one of the files in desktop
3. Optionally select other files from the desktop while keeping Ctrl pressed
4. Press Delete from keyboard
5. Nothing happens, focus stays on Thunar (if file was selected in Thunar,
delete confirmation is shown for it, not for selected desktop files)

Latter bug is valid also if using Shift instead of Ctrl
Comment 1 Brian J. Tarricone (not reading bugmail) 2006-03-03 19:57:30 CET
I'm pretty sure there's nothing I can do about this.  The WM controls who gets
focus after a window is unmapped, right Olivier?
Comment 2 Olivier Fourdan editbugs 2006-03-04 08:36:00 CET
Yeap, the window manager won't give focus back to the desktop unless there is
really no other app that could get focus (I always found that the desktop
getting focus automatically was very confusing).

Now if there is a general consensus that the desktop should be treated like
other apps for xfce 4.4, then I can see what could be done, but keep in mind
that focus management is a fairly touchy beast that needs to be handled with
much care.
Comment 3 Olivier Fourdan editbugs 2006-03-04 10:07:05 CET
Actually, the window manager behaves correctly, it's xfdesktop that is faulty
here ;)

In xfdesktop-file-icon-manager.c, from
xfdesktop_file_icon_manager_delete_selected(), the parent widget that is passed
to xfce_message_dialog() is NULL.

As a result, the modal dialog cannot be "linked" (logically) to the desktop
window. Therefore the window manager cannot return the focus to the parent once
the dialog vanishes.

I'm not sure how to fix that prop
Comment 4 Brian J. Tarricone (not reading bugmail) 2006-03-04 10:57:12 CET
Indeed, fixed.

Your second "bug" is a WM feature.  Try clicking on normal windows while holding
down ctrl.  Same thing happens.  (For future reference: one bug per bug report,
please.)
Comment 5 Mikko Linnalo 2006-03-05 20:59:29 CET
Yeah, I'll keep that in mind. These 2 issues just seemed as a same bug when
reporting this. Fix is working fine --> verified

Bug #1530

Reported by:
Mikko Linnalo
Reported on: 2006-03-03
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Attachments

Additional information