Calibration and profile information buttons are shown in the Color Profiles dialog even when gnome-color-manager is not installed. When these buttons are clicked, the dialog crashes. Since we are probing for gnome-color-manager, could we potentially probe for other tools (like DisplayCAL) as well? Obviously in the case when multiple tools are installed, we would ideally have to have a dialog/dropdown to let the user pick which tool is their preferred one...
Right, so that shouldn't be the case (the buttons should be hidden when gnome-color-manager isn't installed). The reason not to support DisplayCAL is because it conflicts with xiccd, the currently preferred way of applying display profiles to colord. Ideally xiccd will be replaced by server-side support for colord (currently we only have the frontend). To be clear: DisplayCAL has its own daemon that also handles some colord stuff and therefore creates race conditions with xiccd (see https://github.com/agalakhov/xiccd/issues/8 for reference).
Created attachment 8390 Patch ensuring hiding info and calibrate buttons Please test the attached patch.
The patch doesn't work, but... I can't confirm that the code doesn't work. I started investigating and it seems I *do* have gnome-color-manager installed, but it crashes when clicking on the buttons. Maybe this is because my configuration is done with DisplayCAL and that I'm using its daemons etc. and gnome-color-manager is indeed conflicting with xiccd. I wonder if we can probe if gnome-color-manager is working "correctly" (read: is being at all), and only *then* show the buttons.
> I started investigating and it seems I *do* have gnome-color-manager installed. That means the original code works and there's potentially a bug in gcm. Have you tried launching it from the cli to see the about the error message? (gcm-calibrate and gcm-viewer are the base commands) > I wonder if we can probe if gnome-color-manager is working "correctly" (read: is being at all), and only *then* show the buttons. Nope, that's not possible.
gcm-calibrate exits with the message "No device was specified!". (How do I even initialize my devices with gcm?) gcm-viewer does open, but even after importing my profile (with gcm-import), the clicking the profile information button crashes the dialog.
gcm-calibrate expects a colord device as argument, you can get that with "colormgr get-devices". (In any case, that's why I created a GUI for this part of the process ;))
Incidentally, "colormgr get-devices" returns nothing...
Hm, to be honest I'm not sure how to close this report (you have to tell me), but I feel it should be closed. Not sure what else we can do. If gcm-calibrate is installed we show the button. If gcm-calibrate fails silently there's very little we can do... (because that implies a bug in gcm-calibrate)