! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
When GTK_CSD=1 is set in the environment, xfdesktop's background image is dis...
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Tony Morehen 2019-03-30 17:43:49 CET
Created attachment 8368 
Screenshot showing background displacement

I had GTK_OSD=1 set in /etc/environment in 3 of my four computers running an up-to-date Manjaro distribution and xfdesktop 4.13.3.  For those computers, the background image was displaced to the left and up.  See attached screenshot.  The desktop icon were in their normal locations but the hotspots for those icons were also displaced to the left and up.  Removing GTK_OSD=1 restored the background image and hotspots to their correct locations.  My 4th computer did not have GTK_OSD=1 set and xfdesktop presented normally.

This issue was previously discussed in http://forum.xfce.org/viewtopic.php?id=12417.

I filed a bug report because the abnormal behaviour is annoying (especially since the grey bars in my screenshot get filled up with the remnants of any windows that cover them).  The issue is also very hard to debug unless you can find the previous discussion.
Comment 1 Tony Morehen 2019-03-31 20:42:13 CEST
Fumble fingers strikes again (compounded by copy/paste).  GTK_OSD=1 should be GTK_CSD=1
Comment 2 Theo Linkspfeifer editbugs 2019-04-16 14:33:27 CEST
I assume that the easiest solution would be to just unset GTK_CSD in the xfdesktop code.
Comment 3 Tony Morehen 2019-04-16 16:48:23 CEST
I've removed the setting GTK_CSD on all my systems with no noticeable impact other than restoring xfdesktop's normal behaviour.  Why it got set in the first place is a mystery to me.  Unsetting or ignoring that variable would be the best approach.  Whether GTK will allow that or not is another mystery.  It is my hope that this report will save some other poor soul's time.
Comment 4 Theo Linkspfeifer editbugs 2019-06-13 14:45:04 CEST
Created attachment 8628 
proposed patch
Comment 5 Git Bot editbugs 2019-06-17 00:47:24 CEST
Theo Linkspfeifer referenced this bugreport in commit bb2a2fae9e3da79434c1c1e71a30755cc23fd50e

Ensure that CSD is not applied to desktop window (Bug #15241)

https://git.xfce.org/xfce/xfdesktop/commit?id=bb2a2fae9e3da79434c1c1e71a30755cc23fd50e
Comment 6 Andre Miranda editbugs 2019-06-17 00:48:57 CEST
With GTK_CSD=1 here icons are far from borders and rubberband is completely broken, Theo's patch solved the problem, thanks.

Bug #15241

Reported by:
Tony Morehen
Reported on: 2019-03-30
Last modified on: 2019-06-17

People

Assignee:
Eric Koegel
CC List:
2 users

Version

Version:
4.13.4

Attachments

Screenshot showing background displacement (238.77 KB, image/jpeg)
2019-03-30 17:43 CET , Tony Morehen
no flags
proposed patch (819 bytes, patch)
2019-06-13 14:45 CEST , Theo Linkspfeifer
no flags

Additional information