! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-terminal --drop-down does not resize properly after it was in fullscree...
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Frash 2019-03-30 10:46:45 CET
Created attachment 8367 
Screenshot of Manjaro vm after Step 5

How to reproduce:

1) Open a drop-down terminal (xfce4-terminal --drop-down)
2) Move to the drop-down terminal and press F11 to make the terminal fill the screen
3) Close the drop-down terminal in fullscreen mode (xfce4-terminal --drop-down)
4) Open the drop-down terminal again in fullscreen mode (xfce4-terminal --drop-down)
5) Press F11 to exit fullscreen mode

I have a keyboard shortcut to dorp-down the terminal. After this combination the terminal does not resize properly, it only moves to the position it was before the maximization. So the window has still the maximized resolution, but it is moved to the right side (where the terminal originally was). I reproduced this bug on a Manjaro virtual machine. Also, I tried to reproduce it in Mate desktop, but there it worked like expacted. So i think it is a bug in xfwm4 and not in xfce4-terminal. 


Thank you for your great work.
cheers Roland
Comment 1 Frash 2019-03-30 11:14:13 CET
On my host system I have xfwm4 version 4.12.5 installed.
Comment 2 Olivier Fourdan editbugs 2019-04-16 09:40:52 CEST
That's a bug in xfce4-terminal.

Basically, what happens is that when using drop-down, xfce4-terminal sets a minimum size to be equal to the current size.

This can be seen from the terminal itself using the command:

``` 
  $ xprop -id $WINDOWID WM_NORMAL_HINTS
```

Once in fullscreen, the minimum size is updated by xfce4-terminal to be equal to the fullscreen size, meaning that switching back to normal (ie pressing F11 again), the original size cannot be restored as it is constrained by the client to be the fullscreen size.

xfce4-terminal will eventually update the minimum size, but after the window manager has flipped the fullscreen flag, ie too late.

It's basically a race in the client...
Comment 3 Git Bot editbugs 2019-04-20 23:59:19 CEST
Igor referenced this bugreport in commit 2c0794e9670e7839309c17a7014496a822a0eae5

Fix the size of drop-down window after it's been in fullscreen mode

https://git.xfce.org/apps/xfce4-terminal/commit?id=2c0794e9670e7839309c17a7014496a822a0eae5
Comment 4 Igor editbugs 2019-04-20 23:59:50 CEST
Thanks for the report and investigation!
Comment 5 Frash 2019-04-21 06:25:55 CEST
Hi Igor.
Thanks for your effort. I've tested the fix, but the bug still persists.

The command

```
 $ xprop -id $WINDOWID WM_NORMAL_HINTS
```

shows the same output like the older terminal version.
Comment 6 Igor editbugs 2019-04-21 22:02:06 CEST
Hi Roland - this is weird, I cannot reproduce the bug here.

Have you closed all terminal windows (drop-down and "normal" ones) before testing the new version?
Comment 7 Frash 2019-04-22 07:18:58 CEST
You are right.
I didn't know I had to close all the windows.

Thank you for the bug fix :)
Comment 8 Igor editbugs 2019-04-22 14:31:19 CEST
Yes, you have to close all windows since the terminal is a single-process app.

You're welcome!

Bug #15240

Reported by:
Frash
Reported on: 2019-03-30
Last modified on: 2019-04-22

People

CC List:
0 users

Version

Version:
0.8.7.4

Attachments

Additional information