This is related to bug #13076 which demands that Hybrid Sleep was added, which it was. I have it in xfce4-panel v4.13.4. The icon for this Hybrid Sleep action appears to be named system-suspend-hibernate in other desktop environments. My XFCE4 uses the system-hibernate icon for both regular hibernate (sleep/suspend to disk) and hybrid hibernate (suspend to ram and disk). It would be excellent if the hybrid-hibernate option could (ab)use an icon named system-suspend-hibernate instead and perhaps fall back to system-hibernate if that doesn't exist. The result of the current state of affairs is that the same action is shown twice if you have both options shown.
Created attachment 8340 Example of action buttons in Xfce4's panel v4.13.4
Indeed the icon name is the same for regular suspend: https://git.xfce.org/xfce/xfce4-panel/tree/plugins/actions/actions.c?id=987979f88a89942e514588033242d33ab1ceb32e#n193 But here it looks different, with icon themes: Moka, Adwaita and Faenza.
Created attachment 8344 Looks the same to me with Adwaita. Could you show a screenshot of exactly how they look different? The icons look exactly the same to me with the Adwaita theme so I find this very odd. I don't know what is right here, I'm not an icon scientist. I have noticed that a lot of themes do have an icon named system-suspend-hibernate.svg and XFCE4 doesn't use that for anything. It's my personal opinion that it could. Perhaps I am missing something but it appears to me that using the same icon twice would make the two items look the same, and they do on my computer, and using different icons would make them look .. different.
My apologies, now I see the duplicate icons, I was comparing "hybrid sleep" with "suspend" instead of "hibernate". I replaced "system-hibernate" by "system-suspend-hibernate", these are the results here: Adwaita, Gnome: "icon not found" icon Faenza, Moka, Elementary Xfce: same as hibernate icon Are you sure there is a "system-suspend-hibernate" icon? As a matter of fact, not even "system-hibernate" present in the fd.o spec: https://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
>Are you sure no /usr/share/icons/elementary-xfce/apps/64/system-suspend-hibernate.svg /usr/share/icons/Newaita/actions/32/system-suspend-hibernate.svg /usr/share/icons/Suru++/apps/64/system-suspend-hibernate-alt1.svg /usr/share/icons/Suru++/apps/64/system-suspend-hibernate-alt2.svg /usr/share/icons/Suru++/apps/64/system-suspend-hibernate.svg /usr/share/icons/Suru++/apps/64/system-suspend-hibernate-default.svg /usr/share/icons/breeze/actions/32/system-suspend-hibernate.svg /usr/share/icons/breeze-dark/actions/22/system-suspend-hibernate.svg /usr/share/icons/Papirus/48x48/apps/system-suspend-hibernate.svg /usr/share/icons/oxygen/base/48x48/actions/system-suspend-hibernate.png These are the themes I have installed who have an icon named system-suspend-hibernate.. Elementary-Xfce, which is .. specially for Xfce has it yet Xfce doesn't support it. That also appears to be the only non-KDE theme finding this icon to be trendy. Of course, it's just a symlink to -> gnome-session-hibernate.svg and so is system-hibernate.svg so yes, as you say, the same icon is shown. But there is the option of changing the icon so it's different, if Xfce starts supporting it. Newaita, Suru++, Breeze, Papirus and Oxygen are all KDE-focused themes which leads me to believe that KDE absolutely does support this icon name. None of the themes made for eeew GNOME appear to have this icon, instead there's a lot of gnome-session- stuff like gnome-session-hibernate.svg gnome-session-logout.svg gnome-session-sleep.svg gnome-session-suspend.svg and so on. These names do not appear to be aimed towards standardization so my humble opinion is that it would be best to ignore that joke of a mobile phone desktop forced upon desktop computer users. Those people are talking about removing the ability to use themes since it creates a "inconsistent" look from desktop to desktop anyway. As for your "latest" specification document, well, I have looked at that when making my two icon themes and I find that to be .. well, from 2006. 12 years have gone by since then. I suspect they did not have access to Hybrid Suspend technology at that time. The lack of icons in eew GNOME focused icon themes and many other themes indicates that if Xfce does go with system-suspend-hibernate then one should probably be shipped with xfce4-session and placed in the /hicolor/ fallback theme. On the topic of that theme, why is there a bunch of xfsm-hibernate.png xfsm-logout.png xfsm-reboot.png xfsm-shutdown.png xfsm-suspend.png icons there installed by xfce4-session anyway? xfce appers to use the system- ones
Created attachment 8372 action-icon-fallback.diff The attached patch uses the suggested icon name but falls back to "system-hibernate" so we don't break compatibility with Adwaita/Gnome. Are you able to check if it works for you?
Created attachment 8388 Patch works as expected, different icons for suspend/hibernate/hybrid-suspend+hibernate Thank you very much. This patch works for the panel -- but NOT other areas of the Xfce4. I have further complains. Those include a) clicking the exit button brings out a menu "Log out user" with the same choices and []Save session and this patch does not change the icon there. Also, xfce4's power manager lets you choose suspend or hibernate but not hybrid on laptop lid close. I assume I need to file other separate bugs on those.. ? anyway, thank you very much for fixing this one.
Andre Miranda referenced this bugreport in commit 69f14efc0f4418fdd570235af3022b9987218db6 actions: use a different icon for hybrid sleep when possible (Bug #15204) https://git.xfce.org/xfce/xfce4-panel/commit?id=69f14efc0f4418fdd570235af3022b9987218db6
Yes, please file separated bugs.
Andre Miranda referenced this bugreport in commit 308304a338b1b2f6458c1728acb1151495653b02 Use a different icon for hybrid sleep when possible https://git.xfce.org/xfce/xfce4-session/commit?id=308304a338b1b2f6458c1728acb1151495653b02