! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Lost ability to move icons to other screens
Status:
RESOLVED: FIXED
Severity:
critical
Product:
Xfdesktop
Component:
General

Comments

Description ToZ editbugs 2019-03-14 22:26:00 CET
With the latest release of xfdesktop 4.13.3, we have lost the ability to move icons between multiple monitors. This has been reported on the Arch and Xfce forums.

Got myself a second montior and did a git bisect which identified the following commit as the culprit: 

commit 8331081ac2191733b4093ee163812eb0706748d7
Author: Simon Steinbeiss <simon.steinbeiss@elfenbeinturm.at>
Date:   Fri Nov 9 00:58:12 2018 +0100

    Fix iconview items positioning (struts)

Also might be important to note: If I enable "Show icons on primary display", it prevents me from moving icons to other screens (as is intended I assume). If I uncheck it, it automatically moves all icons to the second screen. Any attempt to move an icon back to the first screen leads to a segmentation fault. I can get core dump if it's helpful.
Comment 1 Simon Steinbeiss editbugs 2019-03-16 10:47:17 CET
Sorry, I wasn't even aware you could (I guess by hand?) move icons between displays. I guess I wasn't using xfdesktop that way...

Oddly enough I don't get a segfault though, I only get stuck in start-drag or whatever. If you can provide a backtrace, that could be helpful.
Comment 2 ToZ editbugs 2019-03-16 12:55:56 CET
Does this coredumpctl output help?

           PID: 22047 (xfdesktop)
           UID: 1000 (toz)
           GID: 1000 (toz)
        Signal: 11 (SEGV)
     Timestamp: Thu 2019-03-14 17:21:06 EDT (1 day 14h ago)
  Command Line: xfdesktop -e
    Executable: /usr/bin/xfdesktop
 Control Group: /user.slice/user-1000.slice/session-2.scope
          Unit: session-2.scope
         Slice: user-1000.slice
       Session: 2
     Owner UID: 1000 (toz)
       Boot ID: 6692a3724764414f9c23d5ca30839dff
    Machine ID: 3bf9bec65f7c459fb50adb258da11bf6
      Hostname: archi
       Storage: /var/lib/systemd/coredump/core.xfdesktop.1000.6692a3724764414f9c23d5ca30839dff.22047.15525984660>
       Message: Process 22047 (xfdesktop) of user 1000 dumped core.
                
                Stack trace of thread 22047:
                #0  0x0000555cf00d6404 xfdesktop_icon_get_allowed_drop_actions (xfdesktop)
                #1  0x0000555cf00d879c xfdesktop_icon_view_drag_motion (xfdesktop)
                #2  0x00007ff8ebaea327 n/a (libgtk-3.so.0)
                #3  0x00007ff8eb24be75 g_closure_invoke (libgobject-2.0.so.0)
                #4  0x00007ff8eb2387df n/a (libgobject-2.0.so.0)
                #5  0x00007ff8eb23c76d g_signal_emit_valist (libgobject-2.0.so.0)
                #6  0x00007ff8eb23dd62 g_signal_emit_by_name (libgobject-2.0.so.0)
                #7  0x00007ff8ebac3880 n/a (libgtk-3.so.0)
                #8  0x00007ff8ebac3dec n/a (libgtk-3.so.0)
                #9  0x00007ff8eb94e89c gtk_main_do_event (libgtk-3.so.0)
                #10 0x00007ff8eb64aae6 n/a (libgdk-3.so.0)
                #11 0x00007ff8eb67c985 n/a (libgdk-3.so.0)
                #12 0x00007ff8eb15e7bf g_main_context_dispatch (libglib-2.0.so.0)
                #13 0x00007ff8eb160739 n/a (libglib-2.0.so.0)
                #14 0x00007ff8eb1616d2 g_main_loop_run (libglib-2.0.so.0)
                #15 0x00007ff8eb94d95f gtk_main (libgtk-3.so.0)
                #16 0x0000555cf00d5545 xfdesktop_application_start (xfdesktop)
                #17 0x0000555cf00d58e6 cb_wait_for_window_manager_destroyed (xfdesktop)
                #18 0x00007ff8eb156943 n/a (libglib-2.0.so.0)
                #19 0x00007ff8eb15e428 n/a (libglib-2.0.so.0)
                #20 0x00007ff8eb15e6f0 g_main_context_dispatch (libglib-2.0.so.0)
                #21 0x00007ff8eb160739 n/a (libglib-2.0.so.0)
                #22 0x00007ff8eb16077e g_main_context_iteration (libglib-2.0.so.0)
                #23 0x00007ff8eb316f5e g_application_run (libgio-2.0.so.0)
                #24 0x0000555cf00c6078 main (xfdesktop)
                #25 0x00007ff8eaf32223 __libc_start_main (libc.so.6)
                #26 0x0000555cf00c60be _start (xfdesktop)
                
                Stack trace of thread 22049:
                #0  0x00007ff8eaffec21 __poll (libc.so.6)
                #1  0x00007ff8eb160690 n/a (libglib-2.0.so.0)
                #2  0x00007ff8eb1616d2 g_main_loop_run (libglib-2.0.so.0)
                #3  0x00007ff8eb2d2568 n/a (libgio-2.0.so.0)
                #4  0x00007ff8eb13bc21 n/a (libglib-2.0.so.0)
                #5  0x00007ff8eb0d9a9d start_thread (libpthread.so.0)
                #6  0x00007ff8eb009b23 __clone (libc.so.6)
                
                Stack trace of thread 23715:
                #0  0x00007ff8eaffec21 __poll (libc.so.6)
                #1  0x00007ff8e4a32673 n/a (libpulse.so.0)
                #2  0x00007ff8e4a23990 pa_mainloop_poll (libpulse.so.0)
                #3  0x00007ff8e4a23fe0 pa_mainloop_iterate (libpulse.so.0)
                #4  0x00007ff8e4a24091 pa_mainloop_run (libpulse.so.0)
                #5  0x00007ff8e4a325ae n/a (libpulse.so.0)
                #6  0x00007ff8e47d19fc n/a (libpulsecommon-12.2.so)
                #7  0x00007ff8eb0d9a9d start_thread (libpthread.so.0)
                #8  0x00007ff8eb009b23 __clone (libc.so.6)
                
                Stack trace of thread 22048:
                #0  0x00007ff8eaffec21 __poll (libc.so.6)
                #1  0x00007ff8eb160690 n/a (libglib-2.0.so.0)
                #2  0x00007ff8eb16077e g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007ff8eb1607d2 n/a (libglib-2.0.so.0)
                #4  0x00007ff8eb13bc21 n/a (libglib-2.0.so.0)
                #5  0x00007ff8eb0d9a9d start_thread (libpthread.so.0)
                #6  0x00007ff8eb009b23 __clone (libc.so.6)
Comment 3 Simon Steinbeiss editbugs 2019-03-16 22:41:30 CET
Created attachment 8338 
Patch that re-introduces icons on all screens when not primary

@ToZ: Nvm the backtrace, please test the attached patch. It re-introduces the feature you mentioned.
Comment 4 ToZ editbugs 2019-03-17 00:55:22 CET
Thanks Simon. Tested and it works well. Icons can be moved about as long as Primary monitor is not set. If it is set, icons remain on primary monitor. Icon positions also survive restart.
Comment 5 Simon Steinbeiss editbugs 2019-03-17 08:43:25 CET
@Andre: Feel free to push the patch, it's fairly safe as I just reintegrated what I dropped before.
Not sure if you wanna do a Bugfix Release straight away...
Sorry for the inconvenience!
Comment 6 Git Bot editbugs 2019-03-17 16:03:55 CET
Simon Steinbeiss referenced this bugreport in commit 2d9a081c0ff88cb2c2061beb345d1eb8ec3c070b

Re-introduce ability to move icons to other displays (Bug #15198)

https://git.xfce.org/xfce/xfdesktop/commit?id=2d9a081c0ff88cb2c2061beb345d1eb8ec3c070b
Comment 7 Andre Miranda editbugs 2019-03-17 16:13:46 CET
Looks good to me, but I'll hold the release for now, maybe I release it next weekend, will try to fix a couple of bugs meanwhile.
Thanks Simon and ToZ!
Comment 8 Ettore 2019-03-18 13:10:35 CET
hi,
With the new xfdesktop I have these bugs
conky,and the desk icons are miniature.

https://postimg.cc/ppsZybh5

https://postimg.cc/0byGQ08C
Comment 9 Andre Miranda editbugs 2019-03-24 22:26:56 CET
(In reply to Ettore from comment #8)
> hi,
> With the new xfdesktop I have these bugs
> conky,and the desk icons are miniature.
> 
> https://postimg.cc/ppsZybh5
> 
> https://postimg.cc/0byGQ08C

I can't see what is problem with the first screenshot. With regards the second one, we can change the icon size at Desktop Settings -> Icons -> Icon size.

Either way, this seems to be unrelated to the issue reported here, please file a new bug if you are confident this not a configuration problem.

Bug #15198

Reported by:
ToZ
Reported on: 2019-03-14
Last modified on: 2019-03-24

People

Assignee:
Eric Koegel
CC List:
4 users

Version

Version:
4.13.3

Attachments

Additional information