! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Replace deprecated 'gdk_screen_get_active_window' by Xlib function
Status:
RESOLVED: FIXED
Product:
Xfce4-screenshooter
Component:
General

Comments

Description Olivier Duchateau 2019-03-13 18:18:29 CET
Created attachment 8332 
Replace gdk_screen_get_active_window by Xlib functions

This patch replaces deprecated 'gdk_screen_get_active_window' function. It uses Xlib and Gdk/Gdk-X11.
Comment 1 Andre Miranda editbugs 2019-03-14 00:04:41 CET
Thanks for the patch, I really appreciate, but that's something I want to postpone until gtk4, too much code for one single function :sigh:
Comment 2 Olivier Duchateau 2019-03-14 19:18:28 CET
Problem with G_GNUC_..._IGNORE_DEPRECATIONS macros work only with GCC, with another compiler (e.g., Clang, which is the default compiler on FreeBSD for architectures like amd64, i386 and arm64), we still have warning messages.
Comment 3 Andre Miranda editbugs 2019-03-17 18:07:31 CET
Fair enough, I pushed your patch to master, thanks.
We still have gdk_window_process_all_updates wrapped by those macros, but I'm not sure if it's safe to just remove this function.

Bug #15193

Reported by:
Olivier Duchateau
Reported on: 2019-03-13
Last modified on: 2019-03-17

People

Assignee:
Jérôme Guelfucci
CC List:
1 user

Version

Attachments

Additional information