! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
File system error when taking screenshot from panel plugin and saving to file
Status:
RESOLVED: FIXED
Product:
Xfce4-screenshooter
Component:
General

Comments

Description Guido Falsi 2019-03-12 09:25:22 CET
I'm on FreeBSD but I suspect the problem is not depending on OS. I'm using the latest 1.9.4, which I was testing to update the FreeBSD port.

If I launch Screenshooter from the xfce menu it works fine, and if I tell it to save the screenshot to a file it opens up a requester with a proposed filename.

If I use the panel plugin and choose to save to a file an error window pops up with the following text:

Failed to open "<HOME>" for writing: is a directory


Looks like the recent filename refactoring lost a code path used by the plugin.

If any further information or testing is needed please ask.
Comment 1 Guido Falsi 2019-03-12 18:34:10 CET
I performed some tests in Virtual machines.

Old version (1.9.3) in FreeBSD does not show this behaviour, but works as expected (file requester when saving screenshot to file from panel plugin).

I also tested in a Manjaro Linux Vm, they just updated their packages to include 1.9.4. The same broken behaviour happens there, using the official package.

Can be easily reproduced by adding the screenshoot plugin to the panel, left clicking on it and accepting the default (saving to file).

It definitely looks like a regression.
Comment 2 Olivier Duchateau 2019-03-12 22:29:20 CET
Perhaps origin of this issue, see my comment https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417#c6
Comment 3 Andre Miranda editbugs 2019-03-13 13:11:52 CET
Confirmed, thanks for reporting.
I'll address this regression and release 1.9.5 ASAP.
Comment 4 Olivier Duchateau 2019-03-13 22:00:50 CET
Created attachment 8333 
Fix save action with panel plugin

With following patch, panel plugin works fine (as application). It contains also "cosmetic" changes about prefix URI (I am not used to seeing file:/... However it is valid).
Comment 5 Skunnyk editbugs 2019-03-20 22:22:26 CET
Thank you, it works on top of git version and fix the problem :)
Comment 6 Git Bot editbugs 2019-03-26 02:07:46 CET
Andre Miranda referenced this bugreport in commit 37a344f02ce8d1fb7e2bcaaec75ceeff57af0774

Fix panel plugin: allow it to save files (Bug #15187)

https://git.xfce.org/apps/xfce4-screenshooter/commit?id=37a344f02ce8d1fb7e2bcaaec75ceeff57af0774
Comment 7 Andre Miranda editbugs 2019-03-26 02:10:54 CET
@Olivier, thanks for the patch, but it breaks the feature of passing the directory or file to be saved from CLI.
I pushed a simpler fix, could you please give it a try?
Comment 8 Guido Falsi 2019-03-26 04:24:37 CET
(In reply to Andre Miranda from comment #7)

> I pushed a simpler fix, could you please give it a try?

I applied your patch and it fixes the reported problem for me, so it looks good.
Comment 9 Andre Miranda editbugs 2019-03-30 22:05:00 CET
(In reply to Guido Falsi from comment #8)
> I applied your patch and it fixes the reported problem for me, so it looks
> good.

Thanks for testing.

Bug #15187

Reported by:
Guido Falsi
Reported on: 2019-03-12
Last modified on: 2019-03-30

People

Assignee:
Jérôme Guelfucci
CC List:
3 users

Version

Attachments

Fix save action with panel plugin (3.70 KB, patch)
2019-03-13 22:00 CET , Olivier Duchateau
no flags

Additional information