! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Ristretto randomly renders only part of GIF
Status:
RESOLVED: FIXED
Product:
Ristretto
Component:
Application

Comments

Description Mukundan Ragavan 2019-03-07 00:28:06 CET
Created attachment 8325 
file that does not render completely

Downstream bug report - https://bugzilla.redhat.com/show_bug.cgi?id=1677889

Below is the detailed report left from an end user.

Description of problem:
When I view a particular GIF in Ristretto (the only one I've tried), it randomly gives up partway through rendering it, leaving a grey checkerboard pattern for the bottom part of the image.  The location where Ristretto gives up is not consistent.


Version-Release number of selected component (if applicable):
ristretto-0.8.3-20.fc29.i686

How reproducible:
Sometimes

Steps to Reproduce:
1. Run ristretto on the attached GIF file (not the PNGs, which are screenshots of the problem)

Actual results:
The top of the image is rendered correctly, but the bottom is sometimes rendered as a grey checkerboard.  (See attached PNG screenshots)

Note that sometimes it renders correctly.  In this case, if you click on a different thumbnail, then click back on the GIF, it may render only partially.

Interestingly, the thumbnail is always rendered correctly.

Expected results:
The image renders correctly, every time.

Additional info:
* I ran this from the command line and did not see any useful diagnostic messages about errors.
* The GIF in question (midibujo.gif) was generated by a program called FMSLogo running under wine.
* The same GIF is rendered correctly by Firefox and GIMP.
* I am running a fully patched version of FC29.
* I running on a slow x86 laptop.
* Fedora and xfce are great--without them I would have had to buy a new laptop long ago (several times over).
* When run under valgrind, the grey checkboard looks like random memory, some but no memory corruption is reported.
Comment 1 Mukundan Ragavan 2019-03-07 00:28:35 CET
Created attachment 8326 
partial load in ristretto
Comment 2 Pablo Pazos 2019-06-17 00:45:00 CEST
Created attachment 8636 
error rendering GIF
Comment 3 Pablo Pazos 2019-06-17 00:47:16 CEST
Created attachment 8637 
original image
Comment 4 Pablo Pazos 2019-06-17 00:48:35 CEST
Found the same issue, attached an images and how it is rendered in Ristretto
Comment 5 Olivier Duchateau 2019-06-23 17:55:39 CEST
Problem is not Ristretto, but rather Gdk-Pixbuf. Delay between each frame is 20 milliseconds (it is a default timeout for animation).

We encounter this behaviour in all applications based on Gdk-Pixbuf. If you can, you must increase timeout value (for better render).
Comment 6 Git Bot editbugs 2019-07-12 15:48:36 CEST
Igor referenced this bugreport in commit f1ab0ef82fc96d14cf73c00f55d31581734d80d9

Wait until the loader is done before getting the pixbuf

https://git.xfce.org/apps/ristretto/commit?id=f1ab0ef82fc96d14cf73c00f55d31581734d80d9

Bug #15177

Reported by:
Mukundan Ragavan
Reported on: 2019-03-07
Last modified on: 2019-07-12

People

CC List:
3 users

Version

Attachments

file that does not render completely (8.60 KB, image/gif)
2019-03-07 00:28 CET , Mukundan Ragavan
no flags
partial load in ristretto (35.52 KB, image/png)
2019-03-07 00:28 CET , Mukundan Ragavan
no flags
error rendering GIF (122.74 KB, image/png)
2019-06-17 00:45 CEST , Pablo Pazos
no flags
original image (40.82 KB, image/gif)
2019-06-17 00:47 CEST , Pablo Pazos
no flags

Additional information