! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
same time notification registry override
Status:
RESOLVED: FIXED
Product:
Xfce4-notifyd
Component:
general

Comments

Description becz 2019-03-03 19:55:29 CET
### bug
if multiple notifications have the same date and time, only the last one is registered (yet all displayed).

### how to reproduce
- enable notification registering (e.g. enable "Do not disturb" mode)
- $ for i in {1..10}; do notify-send $i; done # notification burst
- check the registry
Comment 1 inactive 2020-02-23 00:10:21 CET
I can easily get this when running hexchat by doing /msg memoserv help 

Only the last notification is seen in the log:
[2020-02-22T23:55:20]
app_name=io.github.Hexchat
summary=Notice from: MemoServ (freenode)
body=***** End of Help *****
app_icon=hexchat
expire-timeout=-1

I'm guessing the timestamp is used as a key, hence the overwrite...
Comment 2 inactive 2020-02-23 01:22:22 CET
Is there some way to not have to restart X for the changes to xfce4-notifyd to have effect?

I tried, killing the process and `xfce4-panel -r`  to no avail! (even `systemctl reload dbus`, because `restart` does kill X and have to use sysrq to unraw the keyboard for console to work)

It's making patches hard to test if I've to log out of X every time before testing the change.
Comment 3 inactive 2020-02-23 01:25:39 CET
Created attachment 9482 
use miliseconds to make sure group(aka key) is unique

Well anyway, this is a good enough workaround for me.
Still need to find a way to not restart X for testing it though.
Comment 4 inactive 2020-02-23 01:38:06 CET
Well, for whatever reason I was completely oblivious to the fact that there's an xfce4-notifyd process running, and obviously restarting it is the solution instead of restarting X. So killing xfce4-notifyd and running it again.

I was only focused on the likes of this:
/usr/lib/xfce4/panel/wrapper-2.0 /usr/lib/xfce4/panel/plugins/libnotification-plugin.so 4 12582931 notification-plugin Notification Plugin Notification plugin for the Xfce panel

Thanks to EdePopede on channel #xfce on freenode irc for the tip
Comment 5 Simon Steinbeiss editbugs 2020-02-24 23:52:59 CET
The patch works nicely, thanks!
I'm not entirely happy with the format of the timestamp though, I would prefer something like
YYYY-MM-DDThh:mm:ss.sssZ
Comment 6 Simon Steinbeiss editbugs 2020-02-24 23:53:44 CET
If you wanna provide a real git patch - ideally with the aforementioned time format - I'll gladly push it with attribution.
Comment 7 inactive 2020-02-25 11:47:52 CET
Thanks, I appreciate it. However, I will gladly forgo any kind of attribution in favor of allowing you to create the proper/wanted patch for this. Cheers!
Comment 8 Git Bot editbugs 2020-03-01 23:37:47 CET
Simon Steinbeiss referenced this bugreport in commit c9e81d715218b4113764f78d0a1467f19f2d9c5b

Fix logging simultaneous notifications (Bug #15167)

https://git.xfce.org/apps/xfce4-notifyd/commit?id=c9e81d715218b4113764f78d0a1467f19f2d9c5b

Bug #15167

Reported by:
becz
Reported on: 2019-03-03
Last modified on: 2020-03-01

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Attachments

Additional information