Created attachment 8298 Improve GObject introspection annotations This patch improves the GObject introspection annotations, otherwise some methods are not introspectables (see bug #13462).
Quick review: > garcon_menu_directory_set_icon_name (GarconMenuDirectory *directory, > - const gchar *icon_name) > + const gchar *icon) Any reason to rename that parameter? I think icon_name is more descriptive, is aligned with the function name and just "name" makes me think it's some sort of struct such as GIcon. > - static GarconMenuSeparator *separator = NULL; > + GarconMenuSeparator *separator = NULL; > > if (G_UNLIKELY (separator == NULL)) > { Why did you remove that static? Now separator will always be NULL so the if is unnecessary. Couldn't we let the code as is and annotate the returns with (transfer none)? > + * Returns: (transfer full) (nullable): a #GarconMenu or %NULL. > + */ > GarconMenu * > garcon_menu_get_menu_with_name (GarconMenu *menu, Are you sure this one is a transfer full? (There are other get functions that I'm not sure it's supposed to be transfer full).
Thank you for your work Olivier, really appreciated. Can you fix or answer to Andre's review ? Then we can merge it in association with #13462
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/garcon/-/issues/8. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev