! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Ship Xfce with Adwaita window manager styles?
Status:
RESOLVED: WONTFIX

Comments

Description Or Schiro 2019-02-13 14:06:57 CET
Hey guys, 

Adwaita became sort of the de-facto standard GTK theme on Linux.

I was just wondering if we could nicely integrate Adwaita with default Xfce by shipping a dark and a white Adwaita window manager style?

For white: https://www.xfce-look.org/p/1016463/
For dark: https://www.opendesktop.org/p/1277664/

Looking forward to your thoughts! 🎉🤗
Comment 1 Andre Miranda editbugs 2019-02-16 02:14:55 CET
We devs have mostly agreed (or at least not opposed) to promote Greybird as Xfce's default theme [1].
The theme from the first link was last updated in 2015... one of the reasons to pick Greybird is that it's a reliable upstream.

1 - https://mail.xfce.org/pipermail/xfce4-dev/2018-August/thread.html#32152
Comment 2 Or Schiro 2019-02-18 09:40:45 CET
Thanks Andre. 

The only downside I see is that Greybird doesn't feature a well-maintained dark theme mode. 

Adwaita has great support for both white and dark colours.

And looking at the work of @trollpunny [1], he seems to be actively maintaining Adwaita themes for Xfce. 

[1] https://www.opendesktop.org/u/trollpunny/
Comment 3 Olivier Fourdan editbugs 2019-02-18 09:56:42 CET
(In reply to Andre Miranda from comment #1)
> We devs have mostly agreed (or at least not opposed) to promote Greybird as
> Xfce's default theme [1].
No, I never agreed to anything of the sort.

Themes are to customize the look of apps to the liking of the users, devs should not design their apps for any given theme, not even promote any.

And if anything, they should make sure their app looks fine with the *default* theme of the toolkit, i.e. Adwaita, not any other.

> The theme from the first link was last updated in 2015... one of the reasons
> to pick Greybird is that it's a reliable upstream.
Also, you seem to be focusing on the gtk there here, this bug here is about the window manager decorations theme, different things.

(In reply to Robert Orzanna from comment #0)
> Adwaita became sort of the de-facto standard GTK theme on Linux.
It is he default theme shipped with gtk+ so this is the standard.
 
> I was just wondering if we could nicely integrate Adwaita with default Xfce
> by shipping a dark and a white Adwaita window manager style?
xfwm4 default theme adapt to the gtk theme automatically (matching colors), comes in different size for different DPI. etc.

I'm not planning to switch the default theme, that shouldn't stop anyone from installing the themes of their choice though...
Comment 4 Or Schiro 2019-02-19 10:32:37 CET
Hi Olivier, 

> xfwm4 default theme adapt to the gtk theme automatically (matching colors), comes in different size for different DPI. etc.

I didn't know that but now after some testing, this is just brilliant! 🎉😄

Thank you.
Comment 5 Andre Miranda editbugs 2019-02-20 03:17:27 CET
(In reply to Olivier Fourdan from comment #3)
> (In reply to Andre Miranda from comment #1)
> > We devs have mostly agreed (or at least not opposed) to promote Greybird as
> > Xfce's default theme [1].
> No, I never agreed to anything of the sort.
> 
> Themes are to customize the look of apps to the liking of the users, devs
> should not design their apps for any given theme, not even promote any.
> 
> And if anything, they should make sure their app looks fine with the
> *default* theme of the toolkit, i.e. Adwaita, not any other.
What about the themes shipped until 4.12? Xfce didn't have to look good under them, instead Raleigh was the target?
It's exactly because Xfce used to have default themes (not rewritten for gtk3/css) that we came up with the idea to choose a different one than the toolkit's default to *also* be *supported*, i.e. users may pick Adwaita or Greybird, we will do our best to apps look good on them, no guarantee for other themes. The main point here is to Xfce keep a distinct look and feel out of the box, not to be yet another "Gnome remix" (visually speaking).
I'm glad you finally expressed your POV, if you consider it worth, please reiterate this on that mail thread so we may have the opportunity to revisit this matter and maybe settle it for good.

> > The theme from the first link was last updated in 2015... one of the reasons
> > to pick Greybird is that it's a reliable upstream.
> Also, you seem to be focusing on the gtk there here, this bug here is about
> the window manager decorations theme, different things.
And you right, the old window manager decorations themes are still supported in 4.13, nothing changes here, "Default" may continue as the default.
I shouldn't have brought up the default theme discussion, but at least this subject was brought to your attention.

Bug #15140

Reported by:
Or Schiro
Reported on: 2019-02-13
Last modified on: 2019-02-20

People

Assignee:
Olivier Fourdan
CC List:
1 user

Version

Version:
4.13.1

Attachments

Additional information