! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Allow libexo-1 to be disabled
Status:
RESOLVED: FIXED

Comments

Description Olof Kindgren 2019-02-12 23:08:53 CET
exo is one of the very few remaining dependencies on gtk2 on my system. From what I can see, only libexo-1 actually depends on gtk2 and there's nothing on my machine depending on libexo-1. For that reason it would be great to optionally disable building libexo-1 and get rid of the gtk2 dependency
Comment 1 Andre Miranda editbugs 2019-02-13 02:25:46 CET
Created attachment 8294 
wip

Not sure if we should bump libexo_version_api to 2.
Comment 2 Olof Kindgren 2019-02-13 08:57:41 CET
I successfully built with your patch using ./autogen.sh && ./configure --disable-gtk2 --enable-maintainer-mode && make and only get libexo-2

Haven't actually installed it as I'm not sure how to best do that without making my system package manager angry, but I can't see why it would fail if it compiled ok
Comment 3 Git Bot editbugs 2019-02-17 13:54:56 CET
Andre Miranda referenced this bugreport in commit 2097708c789a11b98e40a4aa49adc803613d57c0

Allow libexo-1 to be disabled (bug #15138)

https://git.xfce.org/xfce/exo/commit?id=2097708c789a11b98e40a4aa49adc803613d57c0
Comment 4 Sean Davis editbugs 2019-02-17 13:56:45 CET
Thanks for the patch Andre! I made a small adjustment to make it build correctly when GTK2 is enabled,

GTK_CFLAGS -> GTK2_CFLAGS
GTK_LIBS -> GTK2_LIBS

I don't think the API version needs to be bumped for this change.

Bug #15138

Reported by:
Olof Kindgren
Reported on: 2019-02-12
Last modified on: 2019-02-17

People

Assignee:
Nick Schermer
CC List:
3 users

Version

Attachments

wip (5.47 KB, patch)
2019-02-13 02:25 CET , Andre Miranda
andreldm : review? ( bluesabre )

Additional information