! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Crash/stack smash on some architectures
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfwm4
Component:
General

Comments

Description Martin Husemann 2019-01-09 11:30:49 CET 
Created attachment 8231 
patch, simple and obvious fix

On sparc64 I experienced a crash in xfwm4 which is pretty obvious.

sn_startup_sequence_get_last_active_time takes two long pointer arguments, but xfce4-wm passes pointers to may-be-different types. This may lead to alignment issues or stack smashing depending on the exact types and architecture.

Fix is simple, patch attached.
Comment 1 Martin Husemann 2019-01-09 11:33:15 CET 
Created attachment 8232 
obvious fix
Comment 2 Git Bot editbugs 2019-04-14 21:04:16 CEST 
Martin Husemann referenced this bugreport in commit f68c04ba8591615e5ee615865daf50c23b35ef33

startup-notification: Crash/stack smash on some architectures

https://git.xfce.org/xfce/xfwm4/commit?id=f68c04ba8591615e5ee615865daf50c23b35ef33
Comment 3 Olivier Fourdan editbugs 2019-04-15 22:24:10 CEST 
Applied, thanks.

Bug #15028

Reported by:
Martin Husemann
Reported on: 2019-01-09
Last modified on: 2019-04-15

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
unspecified
Target Milestone:
Xfce 4.12

Attachments

patch, simple and obvious fix (918 bytes, text/x-csrc)
2019-01-09 11:30 CET , Martin Husemann 		no flags
obvious fix (918 bytes, patch)
2019-01-09 11:33 CET , Martin Husemann 		no flags

Additional information