! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
OSC 10;color" doesn't affect bold text
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description olaf 2019-01-03 20:24:41 CET
Created attachment 8224 
Patch against master

When changing the default text color via the OSC-10 escape sequence, the bold text color remains unchanged even if no special color was configured in the GUI / rc-file.

The following command prints a demo line: (and changes the text-color for the terminal to red):

    printf '\e]10;rgb:ff/00/00\e\\normal \e[1mbold\e[0m\n'

Actual output: A line "normal bold" with the word "normal" colored red and the word "bold" remaining in the previous color (white by default)

Expected output: A line "normal bold" with both words colored red

The problem was also reported to the vte library and fixed there nearly a year ago (https://bugzilla.gnome.org/show_bug.cgi?id=793152). This changes the effects of the `vte_terminal_set_color_bold()` function call slightly. The attached patch uses the new calling convention of `bold=NULL` to indicate "use the default FG color".
Comment 1 Git Bot editbugs 2019-01-03 21:28:35 CET
Igor referenced this bugreport in commit b90822b13392f620e4e3770cc3991124f09e7ccf

Fix handling of OSC-10 escape sequence (bold text color)

https://git.xfce.org/apps/xfce4-terminal/commit?id=b90822b13392f620e4e3770cc3991124f09e7ccf
Comment 2 Igor editbugs 2019-01-03 21:29:17 CET
Thanks a lot for the report and the patch, it has been merged!

Bug #15019

Reported by:
olaf
Reported on: 2019-01-03
Last modified on: 2019-01-03

People

CC List:
0 users

Version

Version:
0.8.7.4

Attachments

Patch against master (994 bytes, patch)
2019-01-03 20:24 CET , olaf
no flags

Additional information