! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add functionality to use htop when left-clicking if no xfce4-taskmanager is i...
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Xfce4-cpugraph-plugin
Component:
General

Comments

Description Arvanitis Christos 2019-01-03 18:58:01 CET
Created attachment 8223 
patch for settings.c file

I would like to submit a patch I created for this panel plugin. It seams reasonable to me to use `htop` instead of top if no `xfce4-taskmanager` is installed when left clicking on the panel item. However, in this patch, considering that `htop` is not standard in many distributions,  we firstly check if it is installed, exactly as we do for `xfce4-taskmanager` and if it is not we use `top` as fallback.

This patch refers to the settings.c file of the plugin.
Comment 1 Andre Miranda editbugs 2019-06-22 19:32:04 CEST
Thanks for the patch, but this plugin is part of the Xfce Desktop, thus it is expected to have xfce4-taskmanager installed.

Instead of trying to guess what's the best fallback, we can notify that xfce4-taskmanager is not installed and that it's possible to choose another app in properties -> advanced -> associated command
Comment 2 Git Bot editbugs 2020-05-22 23:39:16 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-cpugraph-plugin/-/issues/5.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15018

Reported by:
Arvanitis Christos
Reported on: 2019-01-03
Last modified on: 2020-05-22

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Version:
unspecified

Attachments

patch for settings.c file (392 bytes, patch)
2019-01-03 18:58 CET , Arvanitis Christos
no flags

Additional information