! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thumbnail rotation error
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description jEsuSdA 2019-01-02 18:27:13 CET
Created attachment 8215 
Comparison between thumbnail and real image orientation.

Hi!

First at all, I think this is a tumbler bug, but could be a Thunar bug. I don't know. ;)

The bug is: thumbnails do not are genearted with the correct orientation. See the attatchment where the picture is "landcape oriented" but the Thunar thumbnail is "portrait oriented".

Thanks!
Comment 1 Andre Miranda editbugs 2019-06-23 23:19:24 CEST
It reminds me of Bug 14644, maybe the picture uses the orientation metadata.
Can you attach the file the is incorrectly thumbnailed?
Comment 2 jEsuSdA 2019-06-24 20:04:16 CEST
Created attachment 8678 
test image
Comment 3 jEsuSdA 2019-06-24 20:07:03 CEST
Created attachment 8679 
thunar thumbnails
Comment 4 jEsuSdA 2019-06-24 20:08:04 CEST
First image:
The actual image.

Second one:
How Thunar shows the thumbnails of the image (the 3rd and 4th appear rotated).
Comment 5 Andre Miranda editbugs 2019-06-30 02:40:45 CEST
Created attachment 8707 
screenshot

Looks good here. Are you using the latest version of tumbler and thunar?
Also try to clear the thumbnail cache (~/.cache/thumbnails).
Comment 6 jEsuSdA 2019-07-01 18:25:10 CEST
Created attachment 8714 
thumnails
Comment 7 jEsuSdA 2019-07-01 18:25:31 CEST
Hi!

I'm using the latest Debian testing packages:
- tumbler - 0.2.3-1
- thunar - 1.8.4-1

The problem still active in images I have edit with Gimp.
Comment 8 jEsuSdA 2019-07-01 18:28:34 CEST
Created attachment 8715 
Original file
Comment 9 Andre Miranda editbugs 2019-07-03 03:25:31 CEST
Created attachment 8718 
tumbler.diff

It's possible to reproduce the issue with the last attached image.

I know almost nothig of exif, possibly this image contains invalid metadata or tumbler's code is naive, because it uses a union to store either tiff or jpeg metadata, but when reading this image both are set (at tvtj_exif_parse_ifd). When thumb_jpeg.orientation is checked, its value is garbled because the union is now supposed to store thumb_tiff.

I was able to fix the problem with the attached diff, however there could be drawbacks besides increased memory usage (very very small AFAICT).
Comment 10 Git Bot editbugs 2019-10-28 17:59:49 CET
Andre Miranda referenced this bugreport in commit 784a76c669128541416eb1959ad8a7454539669d

Fix thumbnail orientation (Bug #15011)

https://git.xfce.org/xfce/tumbler/commit?id=784a76c669128541416eb1959ad8a7454539669d
Comment 11 Andre Miranda editbugs 2019-11-05 00:55:12 CET
*** Bug 16119 has been marked as a duplicate of this bug. ***
Comment 12 jEsuSdA 2019-11-05 11:55:13 CET
Thank you so much! ;)
Comment 13 Marcel Kühlhorn 2019-11-19 15:57:38 CET
I'm sorry but I still see this issue on openSUSE Tumbleweed with Xfce 4.14 / Thunar 1.8.11, should I open a new bug?
Comment 14 Marcel Kühlhorn 2019-11-19 15:59:31 CET
Oops, I just noticed this is a Tumbler bug and there was no release with the fix yet, my bad

Bug #15011

Reported by:
jEsuSdA
Reported on: 2019-01-02
Last modified on: 2019-11-19
Duplicates (1):
  • 16119 Incorrect orientation for large JPEG thumbnail

People

Assignee:
Ali Abdallah
CC List:
3 users

Version

Attachments

Comparison between thumbnail and real image orientation. (914.69 KB, image/png)
2019-01-02 18:27 CET , jEsuSdA
no flags
test image (919.54 KB, image/jpeg)
2019-06-24 20:04 CEST , jEsuSdA
no flags
thunar thumbnails (10.83 KB, image/jpeg)
2019-06-24 20:07 CEST , jEsuSdA
no flags
screenshot (919.54 KB, image/jpeg)
2019-06-30 02:40 CEST , Andre Miranda
no flags
thumnails (12.26 KB, image/png)
2019-07-01 18:25 CEST , jEsuSdA
no flags
Original file (122.79 KB, image/jpeg)
2019-07-01 18:28 CEST , jEsuSdA
no flags
tumbler.diff (5.41 KB, patch)
2019-07-03 03:25 CEST , Andre Miranda
no flags

Additional information