! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar rename dialog resets new name when typing the character "z" quickly
Status:
RESOLVED: FIXED

Comments

Description kharhonte 2018-12-24 09:26:41 CET
When I hit "F2" or right click and rename on a file or folder, I start typing the new name, if I type a lowercase Z, it immediately resets the name the the original and loses my typed new name.

Oddly enough, if I use the arrows or move the focus to another application before typing the Z, if I go back to Thunar and type it, it works.

Can you please have a look at this bug? It become quite annoying losing the typed text every time when you have to type anything with a Z.

Ver 1.8.1git-812e5
Comment 1 Andre Miranda editbugs 2018-12-25 00:43:55 CET
Probably introduced by https://git.xfce.org/xfce/thunar/commit/?id=812e5675a184fd73d5a5125860e71bd2d1eb006d but I can't reproduce.
Which keyboard layout are you using?
Comment 2 kharhonte 2018-12-25 12:58:39 CET
I am using UK layout, I also switched to Italian and I got the same result. Any other way I can help to troubleshoot?

CTRL+Z does exactly the same indeed.
Comment 3 Git Bot editbugs 2018-12-27 01:53:52 CET
Andre Miranda referenced this bugreport in commit 6c8ec358d284d37dcc7bbd36d7e948aa3b409852

Fix undo logic on rename dialog (Bug #14987)

https://git.xfce.org/xfce/thunar/commit?id=6c8ec358d284d37dcc7bbd36d7e948aa3b409852
Comment 4 Andre Miranda editbugs 2018-12-27 01:58:18 CET
Funny, I wasn't able to reproduce with BR layout, at work with US with dead keys ctrl+z simply didn't work.
Finally with US layout I was able to reproduce, it was a stupid logic error.
Closing, reopen if this is still an issue for you.
Comment 5 kharhonte 2018-12-27 21:46:04 CET
Thank you for the help, I guess I either have to wait for the next release or compile and install the patched version.
Comment 6 kharhonte 2018-12-27 21:46:57 CET
Ah! Seen the code, was that "CTRL or Z" instead of CTRL + Z? :)
Comment 7 Git Bot editbugs 2018-12-28 00:41:12 CET
Andre Miranda referenced this bugreport in commit 16b814ec3c7ed71935a284687cea73f117415551

Fix undo logic on rename dialog (Bug #14987)

https://git.xfce.org/xfce/thunar/commit?id=16b814ec3c7ed71935a284687cea73f117415551

Bug #14987

Reported by:
kharhonte
Reported on: 2018-12-24
Last modified on: 2018-12-28

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Attachments

Additional information