! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-panel-profiles cannot backup or export my configuration
Status:
RESOLVED: FIXED
Product:
Xfce4-panel-profiles
Component:
General

Comments

Description Stefan Seyfried 2018-12-02 19:52:07 CET
All I get is
seife@strolchi:~> xfce4-panel-profiles 
Traceback (most recent call last):
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/xfce4-panel-profiles.py", line 220, in on_save_clicked
    self.save_configuration(name)
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/xfce4-panel-profiles.py", line 208, in save_configuration
    PanelConfig.from_xfconf(self.xfconf).to_file(filename)
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/panelconfig.py", line 66, in from_xfconf
    pc.find_desktops()
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/panelconfig.py", line 150, in find_desktops
    self.remove_keys(rem_keys)
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/panelconfig.py", line 157, in remove_keys
    del self.properties[param]
KeyError: '/plugins/plugin-9/style'
Traceback (most recent call last):
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/xfce4-panel-profiles.py", line 233, in on_export_clicked
    self.save_configuration(filename, False)
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/xfce4-panel-profiles.py", line 208, in save_configuration
    PanelConfig.from_xfconf(self.xfconf).to_file(filename)
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/panelconfig.py", line 66, in from_xfconf
    pc.find_desktops()
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/panelconfig.py", line 150, in find_desktops
    self.remove_keys(rem_keys)
  File "/usr/share/xfce4-panel-profiles/xfce4-panel-profiles/panelconfig.py", line 157, in remove_keys
    del self.properties[param]

First try was "Save configuration", second try was "Export configuration".
Comment 1 Stefan Seyfried 2018-12-02 19:56:47 CET
Debugged this with this patch:
--- /dev/shm/panelconfig.py     2018-12-02 19:21:44.934318627 +0100
+++ /usr/share/xfce4-panel-profiles/xfce4-panel-profiles/panelconfig.py 2018-12-02 19:41:04.039082256 +0100
@@ -139,13 +139,17 @@
                 number = path[2].split('-')[1]
                 if pv.get_type_string() == 's' and \
                         pv.get_string() == 'launcher':
+                    print('pp: '+pp+' number: '+number)
                     for d in self.properties['/plugins/plugin-' + number +
                                              '/items'].unpack():
+                        print('d: '+d)
                         desktop_path = 'launcher-' + number + '/' + d
                         if self.check_desktop(desktop_path):
                             self.desktops.append(desktop_path)
                         else:
                             rem_keys.append('/plugins/plugin-' + number)
+                            print('rem_keys.append /plugins/plugin-' +number)

         self.remove_keys(rem_keys)

And I get this:
seife@strolchi:~> xfce4-panel-profiles 
pp: /plugins/plugin-9 number: 9
d: 13352591071.desktop
d: 13077875423.desktop
d: 13085599561.desktop
d: 13104963931.desktop
d: 13077874431.desktop
rem_keys.append /plugins/plugin-9
d: 13077875624.desktop
rem_keys.append /plugins/plugin-9
d: 13077875775.desktop
pp: /plugins/plugin-14 number: 14
d: 15118984981.desktop
pp: /plugins/plugin-15 number: 15
d: 13376025593.desktop
rem_keys.append /plugins/plugin-15


Twice "rem_keys.append /plugins/plugin-9" which later leads to "double delete".
Even if I avoid the double add of plugin-9, then the backup is still useless, because plugin-9 config is not backed up at all.

Plugin-9 is a launcher with 7 entries, two of them "dead" (software is not installed).
Comment 2 Git Bot editbugs 2019-07-27 14:38:40 CEST
Sean Davis referenced this bugreport in commit bdcaa62d1aa33003c17a747a59fbad2d458d2565

Fix KeyError when processing some layouts (bug #14934)

https://git.xfce.org/apps/xfce4-panel-profiles/commit?id=bdcaa62d1aa33003c17a747a59fbad2d458d2565
Comment 3 Sean Davis editbugs 2019-07-27 14:39:27 CEST
The above commit should resolve the issues you reported. Thanks!

Bug #14934

Reported by:
Stefan Seyfried
Reported on: 2018-12-02
Last modified on: 2019-07-27

People

Assignee:
Sean Davis
CC List:
4 users

Version

Version:
unspecified

Attachments

Additional information