! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
`xfce4-notifyd-config --help` shows non-related strings
Status:
RESOLVED: FIXED
Product:
Xfce4-notifyd
Component:
general

Comments

Description Masato Hashimoto 2018-11-29 14:06:43 CET
Created attachment 8140 
Patch to fix help message

`xfce4-notifyd-config --help` shows non-related strings (.po file headers) if the language is not English like follows:

------------------------------------------------------------------------------------------------------------------------------------
$ xfce4-notifyd-config --help
用法:
  xfce4-notifyd-config [OPTION…] Project-Id-Version: Xfce Apps
Report-Msgid-Bugs-To: 
POT-Creation-Date: 2018-02-18 00:31+0100
PO-Revision-Date: 2018-03-20 05:27+0000
Last-Translator: **** **** <****@*****.***>
Language-Team: Japanese (http://www.transifex.com/xfce/xfce-apps/language/ja/)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Language: ja
Plural-Forms: nplurals=1; plural=0;


ヘルプのオプション:
  -h, --help                    ヘルプのオプションを表示する
  --help-all                    ヘルプのオプションをすべて表示する
  --help-gtk                    GTK+ のオプションを表示する

アプリケーションのオプション:
  -V, --version                 バージョン情報を表示する
  -s, --socket-id=SOCKET_ID     設定マネージャーソケット
  --display=DISPLAY             使用するXのディスプレイを指定する
------------------------------------------------------------------------------------------------------------------------------------

Patch attached.
Comment 1 Simon Steinbeiss editbugs 2018-11-30 16:37:02 CET
Odd, the "" parameter is used in many other places of Xfce too. E.g. xfce4-keyboard-settings should expose this problem too.

I also can't reproduce this problem with "LANG=de_AT.UTF-8 xfce4-notifyd-config --help".

You're using ja_JP?
Comment 2 Masato Hashimoto 2018-12-01 13:14:41 CET
Created attachment 8153 
fr and de

> You're using ja_JP?
Yes.
And, fr_FR and de_DE also occur.

Regards
Comment 3 Simon Steinbeiss editbugs 2018-12-03 00:41:01 CET
Here's my output with de_DE:

LANG=de_DE.UTF-8 xfce4-notifyd-config --help

Usage:
  xfce4-notifyd-config [OPTION…] 

Help Options:
  -h, --help                    Show help options
  --help-all                    Show all help options
  --help-gtk                    Show GTK+ Options

Application Options:
  -V, --version                 Display version information
  -s, --socket-id=SOCKET_ID     Settings manager socket
  --display=DISPLAY             X display to use
Comment 4 Skunnyk editbugs 2019-01-02 23:16:56 CET
I can reproduce the problem with LANG=fr_FR.UTF-8 on xfce4-notifyd-config, xfce4-keyboard-settings, xfburn etc… Everywhere gtk_init_with_args is used with "" as parameter_string from what I see.
I never noticed that until now,  maybe it have something to do with the port to gtk3 ?
The use of NULL fix the problem.
Comment 5 Skunnyk editbugs 2019-01-02 23:18:33 CET
The problem occurs with xfburn 0.5.5 (gtk2) so it's not related to the port to gtk3.
Comment 6 Git Bot editbugs 2019-01-02 23:35:54 CET
Masato Hashimoto referenced this bugreport in commit 2d11faf0eb969755406af5f12442d3bf9482c067

Fix output of xfce4-notifyd-config --help (Bug #14922)

https://git.xfce.org/apps/xfce4-notifyd/commit?id=2d11faf0eb969755406af5f12442d3bf9482c067
Comment 7 Simon Steinbeiss editbugs 2019-01-02 23:36:57 CET
Thanks for confirming, Romain!

@Masato: Committed your patch - thanks a bunch!

Bug #14922

Reported by:
Masato Hashimoto
Reported on: 2018-11-29
Last modified on: 2019-01-02

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Attachments

Patch to fix help message (605 bytes, patch)
2018-11-29 14:06 CET , Masato Hashimoto
no flags
fr and de (127.88 KB, image/jpeg)
2018-12-01 13:14 CET , Masato Hashimoto
no flags

Additional information