I have forked xfce4-genmon-plugin and changed it heavily: https://gitlab.com/vala-panel-project/xfce4-genmon-plugin Changes: 1. GTK3 - only. 2. No XFCE-only, I added support for other panels 3. Xfconf for XFCE 4. Used GtkTemplate and UI file for new configuration UI 5. Added <levelbar> tag, which can show a GtkLevelBar (options same as with progressbar) Regressions: 1. Much less integrated into XFCE (does not use Panel Plugin api as used it your version, and does not use XfceTitledDialog anymore).
Hi, and thank you for your interest and work. 1. The genmon plugin has been gkt3-only since 4.0. If you have specific GTK changes that you would like to see, can you prepare a patch file specific to these changes and I will test it. 2. Since this is an Xfce project, the main intent is to provide Xfce-only support. If you can provide a patch set to add other panel support and it doesn't change any of the current functionality, I will review to see if it can be included. But note that I do not want to change the current reliance on Xfce libraries and APIs. 3, 4, 5. Can you please provide patches specific to those changes (one patchset per request) so that I can test them? The preference is to keep this plugin tightly integrated with Xfce. Potential secondary panel support will be considered if there are no significant changes (eg. would like to continue to use the Panel plugin API). Preparing individual patch sets gives me an opportunity to test each of the suggestions individually.
1. It requires GTK 3.22 2. It should have same functionality as current plugin, but it most likely have more generic flavour (because Xfce's API provides flavour, and can be replaced by GTK APIs without losses of functionality). 3,4,5 - Sorry, I cannot provide a patchset fast, because I rewrote main,c almost entirely, so, only file left from upstream is cmdspawn,c. All GenMon functionality on my fork resides in mon_widget.c (and its widget part is UI file now). And config_gui.c converted to GtkTemplate format too. I can provide a big patch, if you want, but I cannot fastly separate each change from main change (rewriting of main.c without any panel dependencies). I can repeat all my work to forking plugin again and then integrate changes side by side. All XFCE API parts (xfconf too) lives in xfce4-panel-genmon.c, and this part is separated from main functionality. What is lost from XFCE integration part: 1. All of XfceTitledDialog (replaced by GtkDialog anywhere). 2. xfce_spawn_command_line_on_screen - replaced by in-house spawn via g_desktop_app_info_launch_uris_as_manager 3. xfce_panel_plugin_add_action_widget for buttons - I can integrate it again into XFCE part, but not to core (it conflicts with goals of the fork - be portable to any panel). For EventBox it is in place, just on XFCE part. I do not know, which functionality I loss by removing of this functions. 4. xfce_create_panel_button - removed due to use of UI files (I not creating widgets in code at all). 5. All xfce_rc_ stuff - replaced to GObject properties and XfConf connections. 6. xfce_panel_pixbuf_from_source - replaced to GIcon handling, but can be easily readded. 7. xfce_get_license_text - just removed (used GtkLicense instead), but it can be easily readded. About testing - I can provide some lesser changes as patches (like <levelbar> support), but changes like GtkTemplate usage will require me to repeat fork rewriting process (from main.c to mon_widget.c). Can you test my fork by your standards?
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-genmon-plugin/-/issues/4. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev