! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
multiple systrays allowed
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Jani Monoses 2006-02-20 20:24:55 CET
When trying to add more than one systray it correctly complains that one is
already registred but add the new systray (or at least a frame for it) nevertheless.

Reproducible: Always
Steps to Reproduce:
1. 
2. 
3.
Comment 1 Jasper Huijsmans editbugs 2006-02-21 08:51:31 CET
Good catch. Should not be too hard to fix.
Comment 2 Jani Monoses 2006-03-08 13:34:59 CET
Indeed, it seems it does not even require any code ;)



Index: plugins/systray/systray.desktop.in.in
===================================================================
--- plugins/systray/systray.desktop.in.in       (revision 20285)
+++ plugins/systray/systray.desktop.in.in       (working copy)
@@ -5,4 +5,4 @@
 _Comment=Show notification icons
 Icon=xfce-system-info
 X-XFCE-Module=@INTERNAL_PLUGIN_PATH@/libsystray.so
-
+X-XFCE-Unique=true
Comment 3 Jani Monoses 2006-03-08 13:43:10 CET
another moment of 'think after send'. This would presumably make systrays on a
different screen non-runnable too.

If so then, there's another problem: construct cannot tell the panel that
initialization failed, so even if we return if another systray is running on
this screen the panel will place the item in panels.xml. Which on restarting the
panel
pops up warnings of systray already registered.

Maybe construct needs to be made to return something to allow plugins to signal
failure initializing for various reasons. Even it's a simple change it may be
too late for 4.4 :(
Comment 4 Jasper Huijsmans editbugs 2006-03-08 19:36:14 CET
It was 'X-XFCE-Unique' originally, but someone requested a change for multiple
screens.

I don't want to change the existing API, but I can add extra macros
*_REGISTER_WITH_CHECK() that can give an additional callback to check whether
new plugins can be created. I have this locally and it works, but I'm not ready
to commit this yet.

I'd like to investigate the possibility of having a X-XFCE-Unique-For-Screen
flag or something.
Comment 5 Jasper Huijsmans editbugs 2006-03-12 09:05:51 CET
Ok, this should now be fixed in revision 20349.

Bug #1482

Reported by:
Jani Monoses
Reported on: 2006-02-20
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Attachments

Additional information