Created attachment 8059 video Hard to word this. Search in Settings and backspace to clear the search leaves many setting options missing. Search in Setttings and use the clear search button leaves Settings with an unusable list. In both methods the return to All Settings is disabled. Attached small video.
Ignore the all settings comment ... Works in 4.12.4
Strange, I can't reproduce this with 4.13.5.
Ok sorry, actually now I can reproduce it. As brainwash mentioned on IRC, if the settings manager window loses focus the correct content is restored.
*** Bug 15054 has been marked as a duplicate of this bug. ***
https://git.xfce.org/xfce/xfce4-settings/tree/xfce4-settings-manager/xfce-settings-manager-dialog.c#n732 Removing or changing this line to gtk_widget_set_sensitive() seems to resolve the bug.
That's a good workaround, I agree. I'm pretty sure the bug is within ExoIconView though. @Sean: What's your take? Shall we 1) push the workaround and port the dialog away from ExoIconView in the future? 2) push the workaround and fix the bug in ExoIconView? 3) not push the workaround and try to fix the bug in ExoIconView immediately?
There's actually a downside to the workaround, it will make the search slower/more expensive, because only visible categories are searched.
Created attachment 8453 diff Instead of checking the visibility of a category we could check the widget’s sensitivity.
Created attachment 8456 Screenshot after clearing the search
The bug isn't actually gone with the _set_sensitive workaround, it just appears less often (see screenshot). I can still reproduce it easily following these steps: 1) type in "xterm" (so no entries are left) 2) clear the search entry 3) type in "xterm" again 4) result is broken categories while deleting single characters plus not all items shown when the entry is cleared
As far as I can tell this bug is in exo, more concretely in exo_icon_view_layout. I'm not sure why the calculations there are off but I suspect it's gtk_widget_get_preferred_size (exo icon view uses the natural over the minimum size, not sure what that results in) as that has been a troublemaker in other components too...
(The hint could be this FIXME https://git.xfce.org/xfce/exo/tree/exo/exo-icon-view.c#n9233)
Sean Davis referenced this bugreport in commit 187eee6d9d3d41404b5c6f1fc56510f780afd703 Fix search change clearing and hiding sections (bug #14792) https://git.xfce.org/xfce/xfce4-settings/commit?id=187eee6d9d3d41404b5c6f1fc56510f780afd703