! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Recent version of Tumbler causing stuttering/freezing while scrolling with Th...
Status:
RESOLVED: MOVED
Product:
Tumbler
Component:
General

Comments

Description carl88990 2018-10-20 02:44:20 CEST
I've noticed a large amount of freezing/stuttering that occurs while scrolling in directories with many video files. I came across the following thread on the XFCE forums where someone had the same issue: https://forum.xfce.org/viewtopic.php?pid=49930

My media folder has several hundred videos, and when scrolling up/down it will freeze and become unresponsive for anywhere between a second or two to 10 or 15 seconds before finishing the scroll. All videos in the folder already have thumbnails generated and displayed. During the freezing, CPU usage for both Thunar and Tumbler is very low.

It started happening recently, around the time Tumbler got updated for my OS (to 0.2.3-1 on Fedora). Thunar hadn't been updated in months and this appears to be related to Tumbler as when I downgraded to an older version of Tumbler (0.2.1-1), I no longer experience any freezing.
Comment 1 carl88990 2018-10-20 02:59:30 CEST
I tried version 0.2.2 as well and experience the same freezing as on 0.2.3, so it appears that 0.2.1 is the last version it doesn't happen on.
Comment 2 Ali Abdallah editbugs 2018-10-20 10:04:13 CEST
Created attachment 8048 
Use stat call only on local files

Thanks for the report. 

Please try out the attached and report back.
Comment 3 carl88990 2018-10-20 19:22:37 CEST
I think I did it correctly, I uninstalled Tumbler and then downloaded the current github source for tumbler and made those changes to that file, and compiled and installed with "sudo ./autogen.sh --prefix=/usr && sudo make && sudo make install".

I still get the freezing with the patch, I think it -might- be because of the way the mount is being reported, assuming the problem is working with remote files. I have a samba share mounted locally to /mnt/sambafolder which I think might be causing it to not work as expected with "g_file_is_native"

https://developer.gnome.org/gio//2.42/GFile.html#g-file-is-native

Since it's a 'locally mounted remote filesystem' it passes this check even though it's remote.
Comment 4 carl88990 2018-10-20 20:31:07 CEST
If I comment out the entire sparse file check statement and install again, the stuttering stops so it does appear to be related to stat on remote files.

I also tried installing gvfs-smb and connecting to the share in Thunar through smb://ipaddress/ instead of my local /mnt/ which uses the 'mount -t cifs ....' command, however I experienced terrible performance in general (freezing for 10+ seconds whenever switching folders), which is one of the reasons I mount a system wide share instead of just in Thunar itself. I'm not sure if it's a gvfs bug, maybe it's some variation of this https://bugzilla.redhat.com/show_bug.cgi?id=1569868 but CIFS local mounts have always worked perfectly for me and allowed easy access from any program I run.
Comment 5 Ali Abdallah editbugs 2018-10-21 11:22:53 CEST
Created attachment 8053 
Move sparse code to plugins
Comment 6 Ali Abdallah editbugs 2018-10-21 11:24:20 CEST
(In reply to carl88990 from comment #4)
> If I comment out the entire sparse file check statement and install again,
> the stuttering stops so it does appear to be related to stat on remote files.
> 

Ok so it seems the sparse check is what is causing the problem for you. 

Could you please try out the new attached patch and report back.
Comment 7 carl88990 2018-10-21 22:22:30 CEST
I downloaded the current github version again, made those changes, compiled & installed, rebooted and it looks like that fixes the stuttering too. Does that mean it's optional and can be enabled in tumbler.rc?
Comment 8 Ali Abdallah editbugs 2018-10-22 08:06:49 CEST
I can add the "check for sparse" option to tumbler.rc, but I'm not sure if that is useful... 

Please do more tests for me, like clearing the cached thumbnails from $HOME/.cache/thumbnails and re-generate the thumbnails again (you can move $HOME/.cache/thumbnails to a temporary directory if you don't want to delete them).
Comment 9 carl88990 2018-10-23 01:44:43 CEST
I deleted the cache and tried again fast scrolling in the folder before+after letting it generate thumbnails and as expected it didn't stutter with the patch before or after generating thumbnails.

I also did tests with the current 2.3.1 version from the repository without the patch, and at first it wasn't stuttering either before or after scrolling with and without the original ~200MB of thumbnails I had.

Then right as I was about to post this, after a few minutes of testing it started freezing again on 2.3.1 without the patch. Now it's stuttering again while scrolling both with and without having any thumbnails generated.
Comment 10 Ali Abdallah editbugs 2018-10-23 14:18:04 CEST
(In reply to carl88990 from comment #9)
> I also did tests with the current 2.3.1 version from the repository without
> the patch, and at first it wasn't stuttering either before or after
> scrolling with and without the original ~200MB of thumbnails I had.
> 
> Then right as I was about to post this, after a few minutes of testing it
> started freezing again on 2.3.1 without the patch. Now it's stuttering again
> while scrolling both with and without having any thumbnails generated.

By 2.3.1 you mean 0.2.3, right? 

To conclude, the proposed patch applied to 0.2.3 solved the stuttering problem, right?
Comment 11 carl88990 2018-10-23 22:14:35 CEST
(In reply to Ali from comment #10)
> (In reply to carl88990 from comment #9)
> > I also did tests with the current 2.3.1 version from the repository without
> > the patch, and at first it wasn't stuttering either before or after
> > scrolling with and without the original ~200MB of thumbnails I had.
> > 
> > Then right as I was about to post this, after a few minutes of testing it
> > started freezing again on 2.3.1 without the patch. Now it's stuttering again
> > while scrolling both with and without having any thumbnails generated.
> 
> By 2.3.1 you mean 0.2.3, right? 
> 
> To conclude, the proposed patch applied to 0.2.3 solved the stuttering
> problem, right?

Yes whenever I compile and install it with those changes I don't get any stuttering or freezing while scrolling. And for 2.3.1 I meant  0.2.3 sorry (it shows as 0.2.3-1 for my distribution's package manager)
Comment 12 Git Bot editbugs 2020-05-25 23:19:59 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/tumbler/-/issues/19.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14777

Reported by:
carl88990
Reported on: 2018-10-20
Last modified on: 2020-05-25

People

Assignee:
Ali Abdallah
CC List:
1 user

Version

Attachments

Use stat call only on local files (2.84 KB, patch)
2018-10-20 10:04 CEST , Ali Abdallah
no flags
Move sparse code to plugins (5.45 KB, patch)
2018-10-21 11:22 CEST , Ali Abdallah
no flags

Additional information