Expected Behavior: When pressing F11 in xfce4-terminal, it should toggle between fullscreen and the original size of the window Observed Behavior: Pressing F11 enables fullscreen and pressing it again briefly flashes the window at the correct size then the window (with window borders enabled) fills the screen minus the xfce panel. Always the first 3 toggles work properly but then once it's un-fullscreened incorrectly once it never works properly again until I completely restart the xfce4-terminal process. The same bug happens when using the regular window titlebar maximize/unmaximize buttons. - I've confirmed this behavior on versions 0.8.6 - 0.8.7.4. - It doesn't happen on versions 0.6.3 - It doesn't happen when using xfwm4 - I'm using Openbox 3.6.1 as my window manager - All my testing was using Xubuntu 18.04.1 - No other windows or terminal emulators that I've tested (sakura, xterm, xfce4-notes, xfce4-settings-manager) exhibit this bug My workaround is to use v0.6.3 for now.
Hi, and thanks for the report! This is an interesting case, I will install openbox and look into it. Side question: do I understand correctly that openbox has been abandoned?
Openbox does seem to be abandoned by the developers but people still use it: https://www.reddit.com/r/openbox/ It's very possible this is an Openbox bug given that it doesn't happen on xfwm4 but then again it only happens with xfwm-terminal 0.8 in Openbox.
I noticed that gnome-terminal behaves the same way under openbox. I also noticed that if you resize the terminal window after un-fullscreening (or un-maximizing) it, it starts to behave normally again. So it isn't necessary to close the window.
It seems I've managed to add some code that resolves the problem under openbox. Hopefully, it won't introduce any new bugs. https://git.xfce.org/apps/xfce4-terminal/commit/?id=b1186b9379d6d90aa2f17f80bf83564c69d0d4ad
Awesome - thanks!
I had to revert the change due to the issue it had caused (see bug 14817). Will have to come up with another solution.
galatians, could you please check if changing the GTK version in the below code to some great value (say, "4, 19, 5") resolves the issue for you? Seems to do the trick for me. Thanks! terminal-screen.c line 2051: #if GTK_CHECK_VERSION (3, 19, 5) NULL, #else screen->terminal, #endif &hints, GDK_HINT_RESIZE_INC | GDK_HINT_MIN_SIZE | GDK_HINT_BASE_SIZE);
Igor referenced this bugreport in commit 50b7f0f4a52e12cb12dc2dce16a764fcaadfe46f Provide geometry_widget to gtk_window_set_geometry_hints https://git.xfce.org/apps/xfce4-terminal/commit?id=50b7f0f4a52e12cb12dc2dce16a764fcaadfe46f
The commit has broken the behavior for other WMs (see bug 15045), will have to find another way to deal with the openbox problem.
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-terminal/-/issues/28. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev