! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
thunar crashed while type chinese with fcitx in search bar
Status:
RESOLVED: FIXED

Comments

Description FateRover 2018-10-11 13:22:48 CEST
step to reproduce 
1.apt install fcitx  fcitx-pinyin (or another pinyin input method:  lib-pinyin )
2.open thunar ,ctrol +f open the search bar ,switch  to pinyin , type some word
3.copy and paste chinese word in search bar isnt affected by this issue



chinese words as test :"测试"
Comment 1 alexxcons editbugs 2018-10-13 21:50:28 CEST
Just installed fcitx + fcitx-pinyin but have trouble to reproduce.

I used some random symbols from "Hiragana" for testing, while I did not find the ones you gave "测试".
Is that the wrong virtual keyboard ? Do I need to configure something else in fcitx to see pinyin in the list ?
Comment 2 FateRover 2018-10-14 09:59:51 CEST
sorry for misleading "测试".  it just to give a demo to show "copy and paste chinese word in search bar isnt affected by this issue"
record a gif  to make it to be rproduced clearly 
https://imgur.com/a/i7escuN

i dont know which one lead this fcitx  or thunar ,but there is another issue :https://bugzilla.xfce.org/show_bug.cgi?id=14463   maybe the same situation
Comment 3 alexxcons editbugs 2018-10-14 20:56:08 CEST
Ah, now I got it .. the shortcut opens some different kind of virtual keyboard
1.) Open thunar
2.) select some file 
3.) CTRL + F (search)
4.) CTRL + SPACE (pidgin)
5.) Hit any key to cause crash

Possibly an exo bug. Here the backtrace:

Thread 1 "thunar" received signal SIGSEGV, Segmentation fault.
exo_icon_view_search_preedit_changed (entry=0x5555559ce6d0, 
    icon_view=0x555555f4ffe0) at exo-icon-view.c:9126
9126	  if (G_LIKELY (icon_view->priv->search_timeout_id != 0))
(gdb) bt
#0  exo_icon_view_search_preedit_changed (entry=0x5555559ce6d0, 
    icon_view=0x555555f4ffe0) at exo-icon-view.c:9126
#1  0x00007ffff4f909e4 in g_cclosure_marshal_VOID__STRINGv ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#2  0x00007ffff4f8e1a4 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#3  0x00007ffff4fa88cd in g_signal_emit_valist ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4  0x00007ffff4fa8fbf in g_signal_emit ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5  0x00007ffff67d917f in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#6  0x00007ffff4f8e1a4 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7  0x00007ffff4fa88cd in g_signal_emit_valist ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#8  0x00007ffff4fa946b in g_signal_emit_by_name ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9  0x00007ffff4f8e1a4 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#10 0x00007ffff4fa88cd in g_signal_emit_valist ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#11 0x00007ffff4fa8fbf in g_signal_emit ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
Comment 4 alexxcons editbugs 2018-10-14 21:29:05 CEST
Created attachment 8036 
patch

Definately an exo bug.

The signature of the signal handler is not correct:

Is:
> exo_icon_view_search_preedit_changed (GtkEntry     *entry,
>                                      ExoIconView  *icon_view)
Should be:
> exo_icon_view_search_preedit_changed (GtkEntry     *entry,
>                                      gchar        *preedit,
>                                      ExoIconView  *icon_view)

So trying to use a gchar as ExoIconView caused the crash.

Here the doc for the signal:
https://developer.gnome.org/gtk3/stable/GtkEntry.html#GtkEntry-preedit-changed

The patch fixes the problem. The search seems to work correct after patching ( however I wonder why "preedit" is not used at all here )
Comment 5 alexxcons editbugs 2018-10-14 21:42:46 CEST
*** Bug 14463 has been marked as a duplicate of this bug. ***
Comment 6 Git Bot editbugs 2018-10-16 02:18:11 CEST
Alexander Schwinn referenced this bugreport in commit f8c5f55d653fa0d2b1cb8a2aceba3e98515fb72b

thunar crashed while type chinese with fcitx in search bar (Bug #14756)

https://git.xfce.org/xfce/exo/commit?id=f8c5f55d653fa0d2b1cb8a2aceba3e98515fb72b
Comment 7 Sean Davis editbugs 2018-10-16 02:21:25 CEST
Fix applied with the above commit. Thanks!
Comment 8 alexxcons editbugs 2018-10-16 21:01:51 CEST
Already released as exo 0.12.3
Thanks Sean !
Comment 9 alexxcons editbugs 2018-10-16 21:16:24 CEST
*** Bug 14764 has been marked as a duplicate of this bug. ***

Bug #14756

Reported by:
FateRover
Reported on: 2018-10-11
Last modified on: 2018-10-16
Duplicates (2):
  • 14463 It crashes if I have installed fcitx-gtk2 and try to input Chinese/Japanese to search files in Thunar.
  • 14764 Out of Bound when using input via Ibus-Unikey to search file

People

Assignee:
Nick Schermer
CC List:
7 users

Version

Version:
unspecified

Attachments

patch (1.44 KB, patch)
2018-10-14 21:29 CEST , alexxcons
no flags

Additional information