! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Window not placed in center despite setting
Status:
RESOLVED: MOVED

Comments

Description Or Schiro 2018-10-08 10:30:21 CEST
Dear all, 

I have recorded this video for you:

https://drive.google.com/file/d/1__J6PTL8vAJDvFjFkK9KHDRlhvZP2ZNB/view

I have chosen the following setting:

Window Manager Tweaks > Placement > Large 100% at the centre of the screen

However, this rule is not being respected for the upload window of the application Flameshot: https://github.com/lupoDharkael/flameshot

Could someone please try to reproduce my problem and confirm whether or not this is a Xfce bug?

Otherwise I am going to report it against Flameshot.

Thank you!

Yours

Robert
Comment 1 Olivier Fourdan editbugs 2018-10-08 11:03:32 CEST
That option (Placement) affects **only** windows that do not specify a location by themselves.

So in that case, the application is most likely specifying a initial location for its window, and xfwm4 honors that request.

No bug there, neither on the application side nor in xfwm4, this is the expected behavior.
Comment 2 Or Schiro 2018-10-08 11:30:58 CEST
Thanks Olivier! So I will report this against Flameshot:

https://github.com/lupoDharkael/flameshot/issues/372

Yours
Comment 3 Olivier Fourdan editbugs 2018-10-08 11:35:19 CEST
But as I said, this is perfectly legit for an application to place its toplevel window on screen in x11, this is not a bug in flameshot.

Again, this is not a bug at all.
Comment 4 Or Schiro 2018-10-08 11:42:45 CEST
Olivier, my point is that the resulting window is opened in a way that doesn't show all available interface buttons. 

I always need to drag the window to the center top to be able to see clickable buttons. 

Do you understand me? Why is this not a bug?

From a user perspective, this is not good to not see the buttons directly.
Comment 5 Olivier Fourdan editbugs 2018-10-09 10:28:05 CEST
Right, what you describe and what is seen in the screencast are two different things....

The screencast shows a window correctly centered on screen who resizes itself up to the point that some of its edges end up outside of the screen/workarea.

The window manager can indeed take care of moving such windows so that they remain fully visible on screen, and xfwm4 will do that in some cases.

But that also causes problems with clients that resize themselves, such as the old xmms for example, in which case the client window will start moving in various directions which is quite unexpected.

For this reason, xfwm4 will do this only for client windows that did not specify a location in their configure request:

  https://git.xfce.org/xfce/xfwm4/tree/src/client.c#n914

This is completely different from the initial placement you're referring to.
Comment 6 Or Schiro 2018-10-09 16:25:16 CEST
Sorry, Olivier! You're right, I was imprecise with my wording. 

But that now that we got it right and understand each other, how shall we move forward? 

I still think this can be improved but just not sure whether on the side of Xfce or Flameshot, because, correct, it's not the initial Flameshot window (this one is placed in the center) but the child resulting from it.
Comment 7 Git Bot editbugs 2020-05-29 12:22:52 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/303.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14742

Reported by:
Or Schiro
Reported on: 2018-10-08
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
4.13.1

Attachments

Additional information