! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Tumbler not longer processing .thumbnailer files
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description ToZ editbugs 2018-09-11 04:30:58 CEST
As of the latest release, tumbler seems to have stopped processing (some?) .thumbnailer files. The one that I am working on is the the customized folder thumbnails (https://docs.xfce.org/xfce/thunar/tumbler#customized_thumbnailer_for_folders).

I did a git bisect, and the offending commit is: https://git.xfce.org/xfce/tumbler/commit/?id=39e1e26a3907bd223f60554a14eb0f5ce93703ff

After this commit, the /usr/bin/folder-thumbnailer executable no longer gets run (I used debug/echo printouts in the script to verify).
Comment 1 Ali Abdallah editbugs 2018-09-11 10:49:06 CEST
What is the output if you launch tumbler manually (probably you have in /usr/lib/tumbler-1/tumblerd)
Comment 2 ToZ editbugs 2018-09-11 12:37:01 CEST
Nothing relevant. I built it with "--enable-debug" and I get the following, but no extra debug info is printed wen I start up thunar (no daemon running). Also, I can't build tumbler with "--enable-debug=full" as I get errors. Here is output:

$ /usr/lib/tumbler-1/tumblerd 
Initializing the Tumbler Cover Thumbnailer plugin
Initializing the Tumbler ODF Thumbnailer plugin
Initializing the Tumbler RAW Thumbnailer plugin
Initializing the Tumbler Poppler PDF/PS Thumbnailer plugin
Initializing the Tumbler GStreamer Thumbnailer plugin
Initializing the Tumbler Pixbuf Thumbnailer plugin
Initializing the Tumbler Desktop Thumbnailer plugin
Initializing the Tumbler Font Thumbnailer plugin
Initializing the Tumbler JPEG Thumbnailer plugin
Initializing the Tumbler ffmpeg video thumbnailer plugin
Shutting down the Tumbler Cover Thumbnailer plugin
Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 304

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 323

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 399

Registered thumbailer ffmpegthumbnailer -i %i -o %o -s %s -f
Registered thumbailer fontimage --o %o --height %s --width %s %i
Registered thumbailer heif-thumbnailer -s %s %i %o
Registered thumbailer /usr/local/bin/folder-thumbnailer %s %i %o %u
Registered thumbailer atril-thumbnailer -s %s %u %o
Registered thumbailer /usr/bin/gdk-pixbuf-thumbnailer -s %s %u %o
Registered thumbailer /usr/bin/gdk-pixbuf-thumbnailer -s %s %u %o
Registered thumbailer /usr/bin/convert -thumbnail %s %i %o
Registered thumbailer gsf-office-thumbnailer -i %i -o %o -s %s
Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 912

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 1026

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 1045

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 1064

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 1520

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 1558

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 2071

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 2090

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 2622

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 2623

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 2889

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 4333

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 4333

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 4336

Registry:
  Preferred Thumbnailers: 0
  Registry Thumbnailers: 4355

Initializing the Tumbler XDG cache plugin
Thumbnailers:

Overrides:
Comment 3 Ali Abdallah editbugs 2018-09-11 19:24:14 CEST
(In reply to ToZ from comment #2)
> $ /usr/lib/tumbler-1/tumblerd 
> 
> Registered thumbailer ffmpegthumbnailer -i %i -o %o -s %s -f
> Registered thumbailer fontimage --o %o --height %s --width %s %i
> Registered thumbailer heif-thumbnailer -s %s %i %o
> Registered thumbailer /usr/local/bin/folder-thumbnailer %s %i %o %u
> Registered thumbailer atril-thumbnailer -s %s %u %o
> Registered thumbailer /usr/bin/gdk-pixbuf-thumbnailer -s %s %u %o
> Registered thumbailer /usr/bin/gdk-pixbuf-thumbnailer -s %s %u %o
> Registered thumbailer /usr/bin/convert -thumbnail %s %i %o
> Registered thumbailer gsf-office-thumbnailer -i %i -o %o -s %s

Those are the desktop thumbnailers found by tumbler, and among them I see the folder-thumnailer that you are working on.
Comment 4 ToZ editbugs 2018-09-12 01:11:51 CEST
Yes, it's registered but it isn't being executed (I put debug statements in the script file).

I spent some more time today looking at this and am to replicate this on another computer. However, it is only affecting the folder-thumbnailer. I tested also using the custom dds desktop thumbnailer and it continues to work fine there.

What I found was that if I comment out the lines:

        if (!S_ISREG (sb.st_mode))
          continue;

then it works again. I'm not 100% sure what this patch is doing, but I think it may be inadvertently catching something else that is affecting the folder thumbnailer.
Comment 5 ToZ editbugs 2018-09-12 01:40:02 CEST
"if (!S_ISREG (sb.st_mode))" is true if the file is a hidden file. I'm using ".folder.png" as the thumbnail file. If I make it un-hidden, "folder.png", then it works again.

Maybe there is a way to also allow through hidden files?
Comment 6 ToZ editbugs 2018-09-12 03:07:15 CEST
Created attachment 7975 
Tumbler ignore hidden files

Here is one patch that fixes the issue from my end, but am not sure of the impact on the intent of the original commit. It basically ignores hidden files in the path.
Comment 7 Ali Abdallah editbugs 2018-09-12 11:44:40 CEST
The issue is fixed in the following commit: 

https://git.xfce.org/xfce/tumbler/commit/?id=b833af4bb782589ad2fa6e13373b483c741924ae
Comment 8 Ali Abdallah editbugs 2018-09-13 15:56:50 CEST
*** Bug 14696 has been marked as a duplicate of this bug. ***

Bug #14693

Reported by:
ToZ
Reported on: 2018-09-11
Last modified on: 2018-09-13
Duplicates (1):
  • 14696 Regression in 0.2.2 : folder thumbnails first show and vanish

People

Assignee:
Ali Abdallah
CC List:
1 user

Version

Attachments

Additional information