! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix uninitialized variable
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description Olivier Duchateau 2018-09-08 18:15:29 CEST
Created attachment 7970 
Fix uninitialized variable

With GCC and also Clang with the latest release 0.2.2 (and also previous) a warning is displayed because erro_code variable is not initialized in tumblerd/  tumbler-group-scheduler.c.

  CC       tumblerd-tumbler-group-scheduler.o
tumbler-group-scheduler.c: In function 'tumbler_group_scheduler_thread':
tumbler-group-scheduler.c:610:7: warning: 'error_code' may be used uninitialized in this function [-Wmaybe-uninitialized]
       g_signal_emit_by_name (request->scheduler, "error", request->handle,
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                              failed_uris, error_code, message->str,
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                              request->origin);
                              ~~~~~~~~~~~~~~~~
Comment 1 Ali Abdallah editbugs 2018-09-11 19:21:08 CEST
Thanks for you report. Your patch has been pushed to master 

https://git.xfce.org/xfce/tumbler/commit/?id=493f35ee50986a2346deca35cfe8cd918ab354fb

Bug #14688

Reported by:
Olivier Duchateau
Reported on: 2018-09-08
Last modified on: 2018-09-11

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Attachments

Fix uninitialized variable (877 bytes, patch)
2018-09-08 18:15 CEST , Olivier Duchateau
no flags

Additional information