! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Improve Spacing in Whisker Menu Preferences


Description Sean Davis editbugs 2018-09-07 04:22:57 CEST
Created attachment 7962 
Improve spacing

The attached patch applies the standard 6/12/18 spacing to the Whisker Menu plugin preferences. The changes are pretty minimal, but should make the dialog feel closer to other Xfce projects. A screenshot of the differences will also be attached.
Comment 1 Sean Davis editbugs 2018-09-07 04:23:28 CEST
Created attachment 7963 

Left: Before, Right: After
Comment 2 Graeme Gott editbugs 2018-09-07 12:09:26 CEST
Created attachment 7966 
Keep xfce_gtk_frame_box_new_with_content

It looks like most of your patch was replacing xfce_gtk_frame_box_new_with_content() with its own frame creation code, which seemed odd to me. What about this patch? Does it match the correct spacing?
Comment 3 Sean Davis editbugs 2018-09-07 12:17:42 CEST
The default spacing applied to the alignment from xfce_gtk_frame_box_new_with_content was:

top 6
left 18

This patch adjusts this to:

top 6
left 12

It also adjusts the spacing between frames to 18px.

These changes are based on the suggestions from https://developer.gnome.org/hig-book/2.32/design-window.html.en
"Indent group members 12 pixels to denote hierarchy and association."
"For vertical spacing between groups of components, 18 pixels is adequate."

We've been using the GNOME 2 HIG as the basis for our own HIG for quite some time, and I've spent the last week applying similar patches to other components (Settings Manager, Xfwm4, panel plugins, Thunar, Thunar Plugins).

Elsewhere, I have replaced xfce_gtk_frame_box_new_with_content with xfce_gtk_frame_box_new to directly manipulate the alignment, but wanted to keep the deprecation-avoiding code to a minimal.
Comment 4 Graeme Gott editbugs 2018-09-07 14:51:58 CEST
I see. I assume at some point you will also patch xfce_gtk_frame_box_new in libxfceui, too, because that is where the left 18 came from (line 152 of xfce-gtk-extensions.c right now). But since not everybody will be using the latest libxfceui, I guess it makes sense to replace xfce_gtk_frame_box_new_with_content with direct manipulation.

I've merged your patch (with some slight tweaks to match my coding style, but not touching the spacing values). If libxfceui gets updated I will just add an #ifdef for future versions to define make_aligned_frame as xfce_gtk_frame_box_new_with_content, so that everybody will have the correct spacing.

Bug #14683

Reported by:
Sean Davis
Reported on: 2018-09-07
Last modified on: 2018-09-07


Graeme Gott
CC List:
0 users




Improve spacing (6.32 KB, patch)
2018-09-07 04:22 CEST , Sean Davis
no flags
Screenshot (71.12 KB, image/png)
2018-09-07 04:23 CEST , Sean Davis
no flags
Keep xfce_gtk_frame_box_new_with_content (5.48 KB, patch)
2018-09-07 12:09 CEST , Graeme Gott
no flags

Additional information