! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PR] Preference Dialog Deprecations & Spacing Improvements
Status:
RESOLVED: MOVED

Comments

Description Sean Davis editbugs 2018-09-03 11:45:40 CEST
Hello! I've prepared a series of patches for the Xfwm preference dialogs. These patches are in my ui-improvements branch [1].

These patches refresh the Glade interface files for Glade 3.22, replace deprecated properties, and improve spacing based on the 6/12/18 standards in the GNOME 2 HIG [2].

Additionally, there are 2 string changes from where I removed newlines that are no longer needed, as the width of the window extends well beyond the length of the strings. Both string changes are found in this commit [3].


[1] https://git.xfce.org/users/bluesabre/xfwm4/log/?h=ui-improvements
[2] https://developer.gnome.org/hig-book/2.32/design-window.html.en
[3] https://git.xfce.org/users/bluesabre/xfwm4/commit/?h=ui-improvements&id=02bcc6d94b5ecf866bf2c43579e5bbbba8ad805c
Comment 1 Sean Davis editbugs 2019-04-22 12:54:37 CEST
I just confirmed that my branch still merges cleanly with git master.
Comment 2 Git Bot editbugs 2020-05-29 12:22:21 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/299.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14658

Reported by:
Sean Davis
Reported on: 2018-09-03
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
4.13.1

Attachments

Additional information