! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use GMutex instead of gint for lock_menu_updates
Status:
RESOLVED: MOVED
Product:
Mousepad
Component:
General

Comments

Description Ricardo Biehl Pasquali 2018-09-02 17:51:06 CEST
File: mousepad-window.c

Perhaps it's racy!

I have not dive into the code, though.

Cheers!
Comment 1 Andre Miranda editbugs 2018-09-02 19:24:22 CEST
But have you experienced any deadlock, or you just read the source and thought this could be improved?
Comment 2 Ricardo Biehl Pasquali 2018-09-03 04:03:47 CEST
(In reply to Andre Miranda from comment #1)
> But have you experienced any deadlock, or you just read the source and
> thought this could be improved?

The latter.
Comment 3 Matthew Brush editbugs 2018-09-05 08:20:22 CEST
It's not multi-threaded code, why use a mutex?

That said, I don't see any obvious reason why it's using a global variable when the MousepadWindow seems to be passed around everywhere.
Comment 4 Git Bot editbugs 2020-05-24 01:30:44 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/mousepad/-/issues/25.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14654

Reported by:
Ricardo Biehl Pasquali
Reported on: 2018-09-02
Last modified on: 2020-05-24

People

Assignee:
Matthew Brush
CC List:
2 users

Version

Version:
Unspecified
Target Milestone:
Mousepad 0.4.x

Attachments

Additional information