Created attachment 7929 build log The video in this link shows the flickering https://www.youtube.com/watch?v=hk0TsYLbZjk&feature=youtu.be This is one a Thinkpad X1 3rd gen (integrated graphics). This flickering is observed in Fedora 29 pre-beta versions. We are planning to include 4.13.x in Fedora 29 and would like to get this sorted out. Complete build log is attached. Let me know what other information is needed. Thanks.
I was getting this same kind of flickering when using the glx-backend, this unreleased commit fixed the problem: https://git.xfce.org/xfce/xfwm4/commit/?id=d6e7fbc4aa17018dd30a7bac1867947d948c9f57 Can you test current git master?
Hmmm ... Building from git master does not seem to work. Build Configuration for xfwm4 version 4.13.1git.UNKNOWN revision UNKNOWN: Startup notification support: yes XSync support: yes Render support: yes Xrandr support: yes Xpresent support: no Embedded compositor: yes Epoxy support: yes KDE systray protocol proxy: no xfwm4-settings.c:51:10: fatal error: xfwm4-dialog_ui.h: No such file or directory #include "xfwm4-dialog_ui.h" ^~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [Makefile:710: xfwm4_settings-xfwm4-settings.o] Error 1 make[3]: Entering directory '/builddir/build/BUILD/xfwm4-4.13.1-git438ebc90/settings-dialogs' CC xfwm4_workspace_settings-workspace-settings.o make[3]: Leaving directory '/builddir/build/BUILD/xfwm4-4.13.1-git438ebc90/settings-dialogs' workspace-settings.c:44:10: fatal error: xfwm4-workspace-dialog_ui.h: No such file or directory #include "xfwm4-workspace-dialog_ui.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [Makefile:766: xfwm4_workspace_settings-workspace-settings.o] Error 1 make[3]: Entering directory '/builddir/build/BUILD/xfwm4-4.13.1-git438ebc90/settings-dialogs' CC xfwm4_settings-range-debouncer.o make[3]: Leaving directory '/builddir/build/BUILD/xfwm4-4.13.1-git438ebc90/settings-dialogs' make[3]: Entering directory '/builddir/build/BUILD/xfwm4-4.13.1-git438ebc90/settings-dialogs' CC xfwm4_tweaks_settings-tweaks-settings.o make[3]: Leaving directory '/builddir/build/BUILD/xfwm4-4.13.1-git438ebc90/settings-dialogs' tweaks-settings.c:48:10: fatal error: xfwm4-tweaks-dialog_ui.h: No such file or directory #include "xfwm4-tweaks-dialog_ui.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~ Not sure if I am doing something wrong though. These files are present in 4.13.1 tarball but not in master. https://git.xfce.org/xfce/xfwm4/tree/settings-dialogs
It is because that file (xfwm4-dialog_ui.h) is generated from xfwm4-dialog.glade. Please, try to configure with --enable-maintainer-mode and make sure exo is installed.
That particular bug is fixed in master, but if you get flickering, that means you're using GLX and not Xpresent, whereas Xpresent is the default. Can you check your build?
https://git.xfce.org/xfce/xfwm4/commit/?id=d6e7fbc4aa17018dd30a7bac1867947d948c9f57 fixes the flickering. What should I check in the build? Logs are at https://kojipkgs.fedoraproject.org//work/tasks/4448/29464448/build.log
here: Package xpresent was not found in the pkg-config search path. Perhaps you should add the directory containing `xpresent.pc' to the PKG_CONFIG_PATH environment variable Package 'xpresent', required by 'virtual:world', not found ... Xpresent support: no
Thanks!
In other words, you need to add “libXpresent-devel” as “BuildRequires” in your spec file, or: BuildRequires: pkgconfig(xpresent)
I've proposed that in https://src.fedoraproject.org/rpms/xfwm4/pull-request/1 I think we can close this as this is now purely downstream bug.
Turns out we have not used xpresent for as long as I have touched this package for some reason. I will enable xpresent. Closing. Thank you Andre and Olivier for prompt responses.