! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Improve spacing, fix button text, add window icon to dialog
Status:
RESOLVED: FIXED
Product:
Thunar-volman
Component:
General

Comments

Description Sean Davis editbugs 2018-09-02 13:46:35 CEST
Created attachment 7927 
Patch for spacing, text, and icon

The attached patch makes a few improvements on thunar-volman master.

1. Spacing is adjusted to line up with the 6/12/18 setup from the GNOME 2 HIG, which we have long used as a stand-in for Xfce's lack of an HIG.
https://developer.gnome.org/hig-book/2.32/design-window.html.en

2. When selecting an application, the dialog's Open button reads "document-open". This patch updates that to say "Select Application".

3. The Select Application dialog did not have an icon set. I've adjusted this to "application-x-executable"
Comment 1 Git Bot editbugs 2018-09-02 18:32:13 CEST
Sean Davis referenced this bugreport in commit 92cf452d5b207849b30d496981fc8fa564c5e102

Improved spacing, fix dialog open button text, add an icon to the open dialog (Bug #14650)

https://git.xfce.org/xfce/thunar-volman/commit?id=92cf452d5b207849b30d496981fc8fa564c5e102
Comment 2 Andre Miranda editbugs 2018-09-02 18:32:46 CEST
Looks good to me, thanks!

Bug #14650

Reported by:
Sean Davis
Reported on: 2018-09-02
Last modified on: 2018-09-02

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Attachments

Patch for spacing, text, and icon (11.05 KB, patch)
2018-09-02 13:46 CEST , Sean Davis
no flags

Additional information